-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduled migrations #3310
Merged
Merged
Scheduled migrations #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to facilitate hard-forking
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
==========================================
- Coverage 53.89% 53.87% -0.02%
==========================================
Files 314 314
Lines 105704 105884 +180
==========================================
+ Hits 56968 57049 +81
- Misses 48736 48835 +99 ☔ View full report in Codecov by Sentry. |
batconjurer
force-pushed
the
bat/feat/scheduled-migrations
branch
from
May 28, 2024 08:36
81a6d7c
to
540e853
Compare
tzemanovic
reviewed
May 28, 2024
tzemanovic
previously approved these changes
May 28, 2024
Co-authored-by: Tomas Zemanovic <[email protected]>
brentstone
added a commit
that referenced
this pull request
May 28, 2024
* bat/feat/scheduled-migrations: Update crates/sdk/src/migrations.rs Added tests Fix typo changelog [feat]: Allow nodes to schedule a migrations json to be read and run to facilitate hard-forking
brentstone
added a commit
that referenced
this pull request
May 28, 2024
* bat/feat/scheduled-migrations: fix clippy + fmt Update crates/sdk/src/migrations.rs Added tests Fix typo changelog [feat]: Allow nodes to schedule a migrations json to be read and run to facilitate hard-forking
sug0
reviewed
May 29, 2024
Co-authored-by: Tiago Carvalho <[email protected]>
tzemanovic
approved these changes
May 30, 2024
brentstone
added a commit
that referenced
this pull request
May 30, 2024
* origin/bat/feat/scheduled-migrations: [fix]: Made migrations module commit modify the shell in-place Update crates/sdk/src/migrations.rs fix clippy + fmt Update crates/sdk/src/migrations.rs Added tests Fix typo changelog [feat]: Allow nodes to schedule a migrations json to be read and run to facilitate hard-forking
brentstone
added a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow nodes to schedule a migrations json to be read and run to facilitate hard-forking. This is done by taking a migrations json and passing the path, a hash of the contents, and a block height to the node when starting the ledger.
Describe your changes
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft