Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled migrations #3310

Merged
merged 8 commits into from
May 31, 2024
Merged

Scheduled migrations #3310

merged 8 commits into from
May 31, 2024

Conversation

batconjurer
Copy link
Member

Allow nodes to schedule a migrations json to be read and run to facilitate hard-forking. This is done by taking a migrations json and passing the path, a hash of the contents, and a block height to the node when starting the ledger.

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@batconjurer batconjurer marked this pull request as draft May 24, 2024 14:27
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 34.15842% with 133 lines in your changes are missing coverage. Please review.

Project coverage is 53.87%. Comparing base (6dc1612) to head (649bc55).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/cli.rs 0.00% 40 Missing ⚠️
crates/sdk/src/migrations.rs 64.77% 31 Missing ⚠️
crates/node/src/lib.rs 0.00% 19 Missing ⚠️
crates/node/src/storage/rocksdb.rs 0.00% 19 Missing ⚠️
crates/node/src/shell/mod.rs 60.00% 8 Missing ⚠️
crates/node/src/shell/testing/node.rs 0.00% 8 Missing ⚠️
crates/storage/src/db.rs 0.00% 5 Missing ⚠️
crates/node/src/shims/abcipp_shim.rs 0.00% 2 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3310      +/-   ##
==========================================
- Coverage   53.89%   53.87%   -0.02%     
==========================================
  Files         314      314              
  Lines      105704   105884     +180     
==========================================
+ Hits        56968    57049      +81     
- Misses      48736    48835      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwgoes cwgoes mentioned this pull request May 27, 2024
@batconjurer batconjurer marked this pull request as ready for review May 27, 2024 08:33
@batconjurer batconjurer force-pushed the bat/feat/scheduled-migrations branch from 81a6d7c to 540e853 Compare May 28, 2024 08:36
tzemanovic
tzemanovic previously approved these changes May 28, 2024
brentstone added a commit that referenced this pull request May 28, 2024
* bat/feat/scheduled-migrations:
  Update crates/sdk/src/migrations.rs
  Added tests
  Fix typo
  changelog
  [feat]: Allow nodes to schedule a migrations json to be read and run to facilitate hard-forking
brentstone added a commit that referenced this pull request May 28, 2024
* bat/feat/scheduled-migrations:
  fix clippy + fmt
  Update crates/sdk/src/migrations.rs
  Added tests
  Fix typo
  changelog
  [feat]: Allow nodes to schedule a migrations json to be read and run to facilitate hard-forking
crates/sdk/src/migrations.rs Outdated Show resolved Hide resolved
crates/sdk/src/migrations.rs Outdated Show resolved Hide resolved
brentstone added a commit that referenced this pull request May 30, 2024
* origin/bat/feat/scheduled-migrations:
  [fix]: Made migrations module commit modify the shell in-place
  Update crates/sdk/src/migrations.rs
  fix clippy + fmt
  Update crates/sdk/src/migrations.rs
  Added tests
  Fix typo
  changelog
  [feat]: Allow nodes to schedule a migrations json to be read and run to facilitate hard-forking
@brentstone brentstone merged commit d25cb83 into main May 31, 2024
17 of 19 checks passed
@brentstone brentstone deleted the bat/feat/scheduled-migrations branch May 31, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants