Only grow wasm memory with write ops #3315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3315 +/- ##
==========================================
+ Coverage 54.05% 54.07% +0.01%
==========================================
Files 315 315
Lines 106296 106344 +48
==========================================
+ Hits 57461 57505 +44
- Misses 48835 48839 +4 ☔ View full report in Codecov by Sentry. |
|
|
This was referenced May 28, 2024
Closed
sug0
force-pushed
the
tiago/wasmer-read-only-mem
branch
from
44cb3d0
to
76628c5
Compare
grarco
approved these changes
Jun 2, 2024
tzemanovic
approved these changes
Jun 3, 2024
Fraccaman
added a commit
that referenced
this pull request
Jun 3, 2024
* up/tiago/wasmer-read-only-mem: Changelog for #3315 Test that RO wasm memory cannot grow Avoid growing wasm memory when performing reads
brentstone
added a commit
that referenced
this pull request
Jun 5, 2024
* origin/tiago/wasmer-read-only-mem: Changelog for #3315 Test that RO wasm memory cannot grow Avoid growing wasm memory when performing reads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3314
Indicate on which release or other PRs this topic is based on
Based on
v0.38.1Checklist before merging to
draft