governance: all vps should allow governance changes #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 54.05% 54.04% -0.02%
==========================================
Files 315 315
Lines 106296 106347 +51
==========================================
+ Hits 57461 57475 +14
- Misses 48835 48872 +37 ☔ View full report in Codecov by Sentry. |
Fraccaman
force-pushed
the
fraccaman/multitoken-allow-governance-changes
branch
from
4460e5b
to
a140a80
Compare
tzemanovic
reviewed
Jun 3, 2024
| _ => { | ||
| tracing::warn!("not sure what happen"); |
There was a problem hiding this comment.
Let's log this as an error - it's when the tx result is missing for the commitment hash
tzemanovic
approved these changes
Jun 3, 2024
Fraccaman
added a commit
that referenced
this pull request
Jun 3, 2024
* up/fraccaman/multitoken-allow-governance-changes: improve integration tests governance can modify all vps substorage fix pgf vp, let governance upgrade pgf storage allow governance to change multitoken storage allow governance to change ibc storage
brentstone
added a commit
that referenced
this pull request
Jun 5, 2024
* origin/fraccaman/multitoken-allow-governance-changes: improve integration tests governance can modify all vps substorage fix pgf vp, let governance upgrade pgf storage allow governance to change multitoken storage allow governance to change ibc storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Superseeds #3328 and #3322.
Governance is now able to modify all VP's sub-storage keys without going though vp validation.
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft