Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masp e2e test #3365

Merged
merged 1 commit into from
Jul 24, 2024
Merged

masp e2e test #3365

merged 1 commit into from
Jul 24, 2024

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jun 4, 2024

Describe your changes

closes #3253
closes #305

Indicate on which release or other PRs this topic is based on

v0.40.0

Checklist before merging to draft

  • [ ] I have added a changelog tests only
  • Git history is in acceptable state

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.47%. Comparing base (8479d38) to head (b6ee545).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3365      +/-   ##
==========================================
- Coverage   53.48%   53.47%   -0.01%     
==========================================
  Files         320      320              
  Lines      110000   110000              
==========================================
- Hits        58832    58823       -9     
- Misses      51168    51177       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic requested a review from grarco June 4, 2024 14:24
grarco
grarco previously approved these changes Jun 4, 2024
Copy link
Contributor

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but this is good, thank you!

@tzemanovic tzemanovic marked this pull request as ready for review June 4, 2024 19:52
grarco
grarco previously approved these changes Jun 4, 2024
@brentstone brentstone dismissed grarco’s stale review June 6, 2024 07:53

The merge-base changed after approval.

@brentstone
Copy link
Collaborator

what is the status here?

@brentstone brentstone mentioned this pull request Jul 8, 2024
@grarco
Copy link
Contributor

grarco commented Jul 9, 2024

what is the status here?

I believe it only needs to be rebased on the latest release

brentstone added a commit that referenced this pull request Jul 10, 2024
* tomas/masp-e2e-test:
  e2e/ledger: revive masp txs and queries test
@brentstone brentstone merged commit 72dc592 into main Jul 24, 2024
18 of 19 checks passed
@brentstone brentstone deleted the tomas/masp-e2e-test branch July 24, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test MASP proof/sig verifications Add E2E Tests for MASP Wallet
3 participants