Murisi/masp ibc replay protection using txdata #3406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
An attempt to address issue #3300. The approach taken is to include the IBC receiver in the pre-image of shielded
Transaction
outputs. More specifically, the following changes have been made:Address
indicating a non-IBC recipientAddress
that corresponds to an transferPacketData
and checking that the transparent inputs and outputs use thatTransaction
go to thereceiver
stated inPacketData
in the case of an outgoing shielded actionTransaction
are the IBC internal address in the case of a refund or an incoming shielded actionCompared to #3320 this PR extracts the IBC messages from the
Tx
instead of the IBC events.Closes #3300
Indicate on which release or other PRs this topic is based on
Namada v0.37.0
Hermes 1.8.2 using this branch for the Namada SDK
Checklist before merging to
draft