Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index batched txs via their wrapper and commitment hashes #3416

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Index batched txs via their wrapper and commitment hashes #3416

merged 3 commits into from
Jul 5, 2024

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Jun 17, 2024 •
edited
Loading

Describe your changes

Closes #3403

Indicate on which release or other PRs this topic is based on

v0.39.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 added enhancement New feature or request UX labels Jun 17, 2024
@sug0 sug0 changed the title Tiago/uniquely identify inner txs Index inner txs in a batch with the wrapper hash Jun 17, 2024
@sug0 sug0 changed the title Index inner txs in a batch with the wrapper hash Index inner txs in a batch with the wrapper and tx commitment hashes Jun 17, 2024
@sug0 sug0 changed the title Index inner txs in a batch with the wrapper and tx commitment hashes Index batched txs with the wrapper and commitment hashes Jun 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.57233% with 77 lines in your changes missing coverage. Please review.

Project coverage is 53.92%. Comparing base (879a326) to head (ec1312b).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/client/tx.rs 0.00% 22 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 14 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 10 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 73.52% 9 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 7 Missing ⚠️
crates/namada/src/ledger/mod.rs 66.66% 5 Missing ⚠️
crates/tx/src/types.rs 0.00% 4 Missing ⚠️
crates/tx/src/data/mod.rs 93.47% 3 Missing ⚠️
crates/node/src/shell/governance.rs 0.00% 2 Missing ⚠️
crates/node/src/shell/finalize_block.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3416      +/-   ##
==========================================
- Coverage   53.92%   53.92%   -0.01%     
==========================================
  Files         317      317              
  Lines      107575   107677     +102     
==========================================
+ Hits        58011    58066      +55     
- Misses      49564    49611      +47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sug0 added a commit that referenced this pull request Jun 18, 2024
@sug0
Changelog for #3416
cf86bda
@sug0 sug0 force-pushed the tiago/uniquely-identify-inner-txs branch from 15477e0 to cf86bda Compare June 18, 2024 08:33
@sug0 sug0 marked this pull request as ready for review June 18, 2024 08:34
@sug0 sug0 requested review from grarco and tzemanovic June 18, 2024 08:34
@sug0 sug0 changed the title Index batched txs with the wrapper and commitment hashes Index batched txs via their wrapper and commitment hashes Jun 18, 2024
grarco
grarco previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

tzemanovic
tzemanovic previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small style nit: I'd re-export either from tx crate since it now appears in its public API so that the other crates don't have to pull it in directly to use it

@sug0 sug0 dismissed stale reviews from tzemanovic and grarco via ec1312b June 19, 2024 08:06
@sug0 sug0 force-pushed the tiago/uniquely-identify-inner-txs branch from cf86bda to ec1312b Compare June 19, 2024 08:06
@sug0 sug0 mentioned this pull request Jun 19, 2024
Closed
brentstone added a commit that referenced this pull request Jun 25, 2024
@brentstone
Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
bd93e34 
* tiago/uniquely-identify-inner-txs:
  Changelog for #3416
  Re-export `either` from `namada_tx`
  Derive inner tx hash using wrapper hash
brentstone added a commit that referenced this pull request Jun 25, 2024
@brentstone
fixup! Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
18f3f62
brentstone added a commit that referenced this pull request Jun 25, 2024
@brentstone
fixup! Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
fe8aea4
brentstone added a commit that referenced this pull request Jun 25, 2024
@brentstone
Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
0c29ee3 
* tiago/uniquely-identify-inner-txs:
  Changelog for #3416
  Re-export `either` from `namada_tx`
  Derive inner tx hash using wrapper hash
brentstone added a commit that referenced this pull request Jun 25, 2024
@brentstone
fixup! Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
b3ae0f7
brentstone added a commit that referenced this pull request Jul 4, 2024
@brentstone
Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
b747e9a 
* origin/tiago/uniquely-identify-inner-txs:
  Changelog for #3416
  Re-export `either` from `namada_tx`
  Derive inner tx hash using wrapper hash
brentstone added a commit that referenced this pull request Jul 4, 2024
@brentstone
fixup! Merge branch 'tiago/uniquely-identify-inner-txs' (#3416)
e366e80
@brentstone brentstone merged commit 22eca3b into main Jul 5, 2024
16 of 19 checks passed
@brentstone brentstone deleted the tiago/uniquely-identify-inner-txs branch July 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grarco grarco grarco left review comments

@tzemanovic tzemanovic tzemanovic left review comments

Assignees
No one assigned
Labels
enhancement New feature or request UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uniquely identify user txs
4 participants
@sug0 @tzemanovic @grarco @brentstone