Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft+3459+3463 #3469

Closed
wants to merge 198 commits into from
Closed

Draft+3459+3463 #3469

wants to merge 198 commits into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Jul 1, 2024

Describe your changes

Testing the combination of #3468 and #3463 .

Indicate on which release or other PRs this topic is based on

#3468
#3463

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

murisi and others added 22 commits June 27, 2024 12:14
* bat/feat/list-and-offer-snapshots:
  rebasing
  tinies
  Added changelog
* fraccaman/limit-pgf-stewards:
  changelog: add #3442
  cleanup
  bug fix: get correct storage key
  fix genesis files
  improve logs
  added maximum amount of stewards as genesis parameter
  ci: update antithesis workflow
  ci: update antithesis workflow
* grarco/sdk-query-height:
  Changelog #2891
  Fallible trait bound for block height param in queries
* brent/parameterize-gas-scale:
  Updated example of expected string
  Fixes ibc e2e test
  fix unit test
  change comment on Gas Display
  fixes from comments
  changelog: add #3391
  fix and clean up
  Light error handling
  remove hard-coded gas scale
  add gas scale to protocol params
* tomas/move-verify-shielded:
  changelog: add #3419
  shielded_token: feature guard validation to avoid compilation into wasm
  move masp validation from SDK into shielded_token crate
* grarco/masp-fee-payment:
  Removes fallback logic when failed fee payment
  Renames misleading gas limit variable
  Removes useless write-log commit in fee payment
  Fixes typo
  Fixes masp amounts conversion
  Fixes broken docs
  Reuses token transfer
  Fixes typo
  Panics in fee payment if balance read fails
  Changelog #3393
  Adds missing gas spending key arg to ibc tx
  Masp fee payment for shielded actions
  Fixes masp tx generation and integration tests
  Updates shielded wasm code to handle fee unshielding
  Removes unused denominate function
  Adds support for masp fee payment in sdk
  Refactors the write log api
  Different gas cost for storage deletes
  Removes write log precommit and leverages the batch log
  Adds integration tests for masp fee payment
  Refactors batch execution in case of masp fee payment
  Skips the execution of the first inner tx when masp fee payment
  Renames fee payment gas limit parameter
  Returns `BatchedTxResult` from masp fee payment
  `check_fees` drop the storage changes in case of failure
  `check_fees` checks masp fee payment
  Reworks masp fee payment to correctly handle errors. Misc refactors
  Passes the correct tx index to masp fee payment check
  Introduces masp fee payment
* grarco/early-sapling-balance-check:
  Extracts the sapling value balance directly in `validate_transparent_bundle`
  Changelog #2721
  Early sapling balance check in masp vp
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 35.40094% with 2739 lines in your changes missing coverage. Please review.

Project coverage is 53.50%. Comparing base (879a326) to head (2d51bea).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp.rs 0.48% 616 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 381 Missing ⚠️
crates/namada/src/ledger/native_vp/masp.rs 0.00% 307 Missing ⚠️
crates/apps_lib/src/cli.rs 0.00% 169 Missing ⚠️
crates/shielded_token/src/validation.rs 0.00% 158 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 86 Missing ⚠️
crates/token/src/lib.rs 0.00% 83 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 77.58% 78 Missing ⚠️
crates/core/src/masp.rs 2.77% 70 Missing ⚠️
crates/node/src/shell/governance.rs 1.56% 63 Missing ⚠️
... and 43 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3469      +/-   ##
==========================================
- Coverage   53.92%   53.50%   -0.43%     
==========================================
  Files         317      319       +2     
  Lines      107575   109725    +2150     
==========================================
+ Hits        58011    58705     +694     
- Misses      49564    51020    +1456     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants