Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBC MASP tx extraction #3490

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix IBC MASP tx extraction #3490

merged 3 commits into from
Jul 24, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jul 5, 2024

Describe your changes

closes #3488

Indicate on which release or other PRs this topic is based on

v0.40.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 requested a review from grarco July 5, 2024 20:43
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 38.79310% with 71 lines in your changes missing coverage. Please review.

Project coverage is 53.44%. Comparing base (8479d38) to head (f4ee4d3).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/namada/src/ledger/protocol/mod.rs 47.16% 28 Missing ⚠️
crates/sdk/src/masp.rs 0.00% 26 Missing ⚠️
crates/core/src/ibc.rs 0.00% 7 Missing ⚠️
crates/tx/src/data/mod.rs 60.00% 4 Missing ⚠️
crates/events/src/extend.rs 0.00% 3 Missing ⚠️
crates/node/src/shell/finalize_block.rs 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3490      +/-   ##
==========================================
- Coverage   53.48%   53.44%   -0.04%     
==========================================
  Files         320      320              
  Lines      110000   110072      +72     
==========================================
+ Hits        58832    58833       +1     
- Misses      51168    51239      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yito88 yito88 force-pushed the yuji/fix-ibc-masp-tx-extraction branch from 4d97fc1 to f563af1 Compare July 5, 2024 21:49
@brentstone brentstone mentioned this pull request Jul 5, 2024
crates/events/src/extend.rs Outdated Show resolved Hide resolved
brentstone added a commit that referenced this pull request Jul 11, 2024
* yuji/fix-ibc-masp-tx-extraction:
  check ibc masp action
  add IbcTxDataRefs
Copy link
Contributor

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

brentstone added a commit that referenced this pull request Jul 11, 2024
* yuji/fix-ibc-masp-tx-extraction:
  fix KEY name
  check ibc masp action
  add IbcTxDataRefs
@brentstone brentstone merged commit 01285b3 into main Jul 24, 2024
17 of 20 checks passed
@brentstone brentstone deleted the yuji/fix-ibc-masp-tx-extraction branch July 24, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shielded action events
3 participants