Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename and split --memo-path of ibc-transfer #3519

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jul 16, 2024

Describe your changes

closes #3517

Indicate on which release or other PRs this topic is based on

v0.40.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 requested a review from Fraccaman July 16, 2024 13:48
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 7.40741% with 50 lines in your changes missing coverage. Please review.

Project coverage is 53.46%. Comparing base (8479d38) to head (2345a41).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/cli.rs 0.00% 21 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 19 Missing ⚠️
crates/sdk/src/args.rs 0.00% 8 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3519      +/-   ##
==========================================
- Coverage   53.48%   53.46%   -0.02%     
==========================================
  Files         320      320              
  Lines      110000   110024      +24     
==========================================
- Hits        58832    58824       -8     
- Misses      51168    51200      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brentstone added a commit that referenced this pull request Jul 17, 2024
* yuji/rename-ibc-transfer-memo-opt:
  rename and split --memo-path of ibc-transfer
@brentstone brentstone mentioned this pull request Jul 17, 2024
@brentstone brentstone merged commit e5c55ab into main Jul 24, 2024
17 of 19 checks passed
@brentstone brentstone deleted the yuji/rename-ibc-transfer-memo-opt branch July 24, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--memo-path of ibc-transfer is confusing with Namada transaction memo --memo
3 participants