Murisi/borsh ibc msg transfer #3527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. The corresponding Transfers now match these.
…ated for IBC transfer.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3527 +/- ##
==========================================
- Coverage 53.48% 53.08% -0.40%
==========================================
Files 320 320
Lines 110000 110794 +794
==========================================
- Hits 58832 58815 -17
- Misses 51168 51979 +811 ☔ View full report in Codecov by Sentry. |
yito88
reviewed
Jul 19, 2024
| let mut data = vec![]; | ||
| prost::Message::encode(&msg.to_any(), &mut data).unwrap(); | ||
| let data = IbcMessage::Envelope(Box::new( | ||
| MsgEnvelope::from(ConnectionMsg::from(msg)).into(), |
There was a problem hiding this comment.
It's OK. MsgEnvelope::Connection(msg.into()) can be simple because we don't need to import ConnectionMsg explicitly ?
| @@ -104,11 +105,16 @@ where | |||
| let tx_data = | |||
| batched_tx.tx.data(batched_tx.cmt).ok_or(Error::NoTxData)?; | |||
|
|
|||
| // Message body must be an IbcMessage | |||
| let tx_data = IbcMessage::try_from_slice(&tx_data) | |||
There was a problem hiding this comment.
I prefer using message instead of tx_data for the following functions.
Suggested change
| let tx_data = IbcMessage::try_from_slice(&tx_data) | |
| let message = IbcMessage::try_from_slice(&tx_data) |
| @@ -184,7 +190,7 @@ where | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn validate_with_msg(&self, tx_data: &[u8]) -> VpResult<()> { | |||
| fn validate_with_msg(&self, tx_data: IbcMessage) -> VpResult<()> { | |||
There was a problem hiding this comment.
Suggested change
| fn validate_with_msg(&self, tx_data: IbcMessage) -> VpResult<()> { | |
| fn validate_with_msg(&self, message: IbcMessage) -> VpResult<()> { |
murisi
force-pushed
the
murisi/borsh-ibc-msg-transfer
branch
from
474fb23
to
3c2ad18
Compare
|
Closed in favour of the rebase in #3560 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Attempt to close #3501 and hence simplify the (de)serialization of IBC transactions for third parties. More specifically, the following changes have been made:
IbcMessageenumeration instead of being an untagged serialization of aMsgTransfer,MsgNftTransferorAnystructure.Txare serialized using Borsh, and will ease schema generation.Indicate on which release or other PRs this topic is based on
Namada 0.40.0
Checklist before merging to
draft