Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grarco/outsource masp sig verification rebase murisi #3528

Closed

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Jul 18, 2024

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 12.14953% with 94 lines in your changes missing coverage. Please review.

Project coverage is 53.46%. Comparing base (8479d38) to head (dab10a6).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/namada/src/ledger/native_vp/masp.rs 0.00% 82 Missing ⚠️
crates/tx/src/action.rs 54.54% 5 Missing ⚠️
crates/trans_token/src/storage.rs 0.00% 4 Missing ⚠️
crates/tx_prelude/src/token.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3528      +/-   ##
==========================================
- Coverage   53.48%   53.46%   -0.02%     
==========================================
  Files         320      320              
  Lines      110000   110031      +31     
==========================================
- Hits        58832    58828       -4     
- Misses      51168    51203      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco force-pushed the grarco/outsource-masp-sig-verification-rebase-murisi branch from 516b60b to d2f84e9 Compare July 19, 2024 15:55
@grarco grarco force-pushed the grarco/outsource-masp-sig-verification-rebase-murisi branch from d2f84e9 to dab10a6 Compare July 19, 2024 16:17
@grarco grarco closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants