-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize state sync snapshot format #3701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
bat/snapshot-improvements
branch
2 times, most recently
from
August 26, 2024 18:25
6ce1cd2
to
353a79b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3701 +/- ##
==========================================
+ Coverage 61.25% 61.50% +0.25%
==========================================
Files 315 315
Lines 103196 103880 +684
==========================================
+ Hits 63209 63896 +687
+ Misses 39987 39984 -3 ☔ View full report in Codecov by Sentry. |
tzemanovic
reviewed
Aug 27, 2024
tzemanovic
reviewed
Aug 27, 2024
batconjurer
force-pushed
the
bat/snapshot-improvements
branch
from
August 27, 2024 08:55
353a79b
to
ed19c65
Compare
sug0
force-pushed
the
bat/snapshot-improvements
branch
2 times, most recently
from
August 27, 2024 09:09
5caa1fc
to
9d83731
Compare
tzemanovic
approved these changes
Aug 27, 2024
@Mergifyio refresh |
✅ Pull request refreshed |
@Mergifyio refresh |
✅ Pull request refreshed |
batconjurer
force-pushed
the
bat/snapshot-improvements
branch
from
August 28, 2024 08:55
d27170f
to
705d951
Compare
sug0
force-pushed
the
bat/snapshot-improvements
branch
from
August 28, 2024 09:47
705d951
to
f027fca
Compare
sug0
force-pushed
the
bat/snapshot-improvements
branch
from
August 28, 2024 09:49
f027fca
to
a2e067f
Compare
@Mergifyio refresh |
✅ Pull request refreshed |
sug0
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
These changes optimize the format of snapshots taken for state syncing purposes. Snapshots are taken over the entire RocksDB database, packaged into a
zstd
compressedtar
archive, and split into 10 MB chunks.Checklist before merging
breaking::
labels