Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge queue: embarking main (cc0a448), #3691 and #3702 together #3727

Closed
wants to merge 16 commits into from
Closed

merge queue: embarking main (cc0a448), #3691 and #3702 together #3727

wants to merge 16 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 29, 2024 •
edited
Loading

✨ Pull request #3691 which was ahead in the queue has been dequeued. The pull request #3702 has been re-embarked. ✨

Branch main (cc0a448), #3691 and #3702 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3702.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • any of [🛡 GitHub branch protection]:
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
    • check-success=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-unit
    • check-skipped=test-unit
    • check-success=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
    • check-success=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
    • check-success=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
    • check-success=test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
    • check-success=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
    • check-success=test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-integration
    • check-skipped=test-integration
    • check-success=test-integration
  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=check-packages
    • check-neutral=check-packages
    • check-skipped=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success=build-binaries
    • check-neutral=build-binaries
    • check-skipped=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • any of [🛡 GitHub branch protection]:
    • check-success=lints
    • check-neutral=lints
    • check-skipped=lints
  • any of [🛡 GitHub branch protection]:
    • check-success=test-wasm
    • check-neutral=test-wasm
    • check-skipped=test-wasm

Required conditions to stay in the queue:

  • #approved-reviews-by >= 1
  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • base = main
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=check-benchmarks
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success=check-packages
    • check-neutral=check-packages
    • check-skipped=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success=build-binaries
    • check-neutral=build-binaries
    • check-skipped=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • any of [🛡 GitHub branch protection]:
    • check-success=lints
    • check-neutral=lints
    • check-skipped=lints
  • any of [🛡 GitHub branch protection]:
    • check-success=test-unit
    • check-neutral=test-unit
    • check-skipped=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (0)
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (1)
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (2)
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (3)
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (4)
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-integration
    • check-neutral=test-integration
    • check-skipped=test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success=test-wasm
    • check-neutral=test-wasm
    • check-skipped=test-wasm
---
previous_failed_batches: []
pull_requests:
  - number: 3702
...

egasimus and others added 16 commits August 26, 2024 19:26
@egasimus
derive Serialize for PosParams and OwnedPosParams
704b193 
this would enable our client library `@fadroma/namada` to automatically convert the response from `/vp/pos/pos_params` without having to explicitly list every field (see https://github.com/hackbg/fadroma/blob/e7d5d551f818a6441ef54309a2517792b03ee7d3/packages/namada/src/decode.rs#L201-L223)
@egasimus
derive Serialize for GovernanceParameters
0e88348 
this would enable @fadroma/namada to automatically serialize the response from `/vp/governance/parameters` to JSON without having to explicitly list each field (see https://github.com/hackbg/fadroma/blob/e7d5d551f818a6441ef54309a2517792b03ee7d3/packages/namada/src/decode.rs#L201-L223)
@egasimus
remove unused serde::Deserialize import
1673caf
@egasimus
fix clippy lint in around PosParams and OwnedPosParams
f34c144
@egasimus
chore: make fmt
a42a802
@egasimus
chore: update changelog
18a1fed
@brentstone
add queries for total supply
0e3fbc1
@brentstone
fix some logging and CLI functionality
46524b8
@brentstone
testing
97bb9f3
@brentstone
changelog: add #3691
f8c679a
@brentstone
format denominated amount
526c261
@brentstone
better error handling for sdk query in client
f57a1a9
@egasimus
move changelog entry from invalid directory
66ea996
@egasimus
Merge branch 'main' into main
2af1972
@mergify
Merge of #3691
941efd5
@mergify
Merge of #3702
3943892
@mergify mergify bot closed this Aug 29, 2024
@mergify mergify bot deleted the mergify/merge-queue/7ab6a1ad6f branch August 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egasimus @brentstone