-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the signing logic to fall back to the hardware wallet if secret key is not found. #3730
Conversation
31dd498
to
7db8565
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3730 +/- ##
=======================================
Coverage 72.68% 72.69%
=======================================
Files 338 338
Lines 104319 104339 +20
=======================================
+ Hits 75826 75849 +23
+ Misses 28493 28490 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
f49e38b
to
24e790a
Compare
Describe your changes
Currently the transaction signing logic fails fall back to the hardware wallet if the secret key is not found in the wallet store. This is because an error is propagated as soon as the secret key lookup fails. This PR fixes that. Additionally, the signing code now checks that the number of public keys used in signing exceeds the given account's threshold.
Checklist before merging
breaking::
labels