Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the signing logic to fall back to the hardware wallet if secret key is not found. #3730

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Aug 30, 2024

Describe your changes

Currently the transaction signing logic fails fall back to the hardware wallet if the secret key is not found in the wallet store. This is because an error is propagated as soon as the secret key lookup fails. This PR fixes that. Additionally, the signing code now checks that the number of public keys used in signing exceeds the given account's threshold.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@murisi murisi force-pushed the murisi/enable-hw-fallback branch 2 times, most recently from 31dd498 to 7db8565 Compare August 30, 2024 07:53
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (0d7140f) to head (24e790a).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/signing.rs 38.46% 16 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3730   +/-   ##
=======================================
  Coverage   72.68%   72.69%           
=======================================
  Files         338      338           
  Lines      104319   104339   +20     
=======================================
+ Hits        75826    75849   +23     
+ Misses      28493    28490    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Fraccaman Fraccaman added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 8, 2024
mergify bot added a commit that referenced this pull request Sep 8, 2024
mergify bot added a commit that referenced this pull request Sep 8, 2024
@mergify mergify bot merged commit 15f659b into main Sep 8, 2024
22 of 23 checks passed
@mergify mergify bot deleted the murisi/enable-hw-fallback branch September 8, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants