Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor token transfer and add more tests #3736

Merged
merged 13 commits into from
Sep 23, 2024
Merged

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Aug 30, 2024

Describe your changes

Moves the transfer code out of wasm into the token crates and adds more tests

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 87.86280% with 92 lines in your changes missing coverage. Please review.

Project coverage is 73.01%. Comparing base (e29da65) to head (c3cbda3).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
crates/token/src/tx.rs 71.71% 56 Missing ⚠️
crates/tx_prelude/src/token.rs 6.66% 14 Missing ⚠️
crates/trans_token/src/tx.rs 97.96% 10 Missing ⚠️
crates/tx_prelude/src/lib.rs 0.00% 5 Missing ⚠️
wasm/tx_ibc/src/lib.rs 0.00% 5 Missing ⚠️
crates/token/src/lib.rs 96.66% 1 Missing ⚠️
wasm/tx_transfer/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3736      +/-   ##
==========================================
+ Coverage   72.82%   73.01%   +0.18%     
==========================================
  Files         338      340       +2     
  Lines      104220   104750     +530     
==========================================
+ Hits        75897    76481     +584     
+ Misses      28323    28269      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic force-pushed the tomas/refactor-token-transfer branch 3 times, most recently from 6a62657 to 708bce9 Compare September 13, 2024 12:12
@tzemanovic tzemanovic changed the title refactor token transfer refactor token transfer and add more tests Sep 13, 2024
@brentstone brentstone added this to the v0.44.0 milestone Sep 18, 2024
@tzemanovic tzemanovic marked this pull request as ready for review September 19, 2024 10:11
tzemanovic added a commit that referenced this pull request Sep 19, 2024
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 23, 2024
mergify bot added a commit that referenced this pull request Sep 23, 2024
@mergify mergify bot merged commit 760462b into main Sep 23, 2024
24 checks passed
@mergify mergify bot deleted the tomas/refactor-token-transfer branch September 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants