-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor token transfer and add more tests #3736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3736 +/- ##
==========================================
+ Coverage 72.82% 73.01% +0.18%
==========================================
Files 338 340 +2
Lines 104220 104750 +530
==========================================
+ Hits 75897 76481 +584
+ Misses 28323 28269 -54 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/refactor-token-transfer
branch
3 times, most recently
from
September 13, 2024 12:12
6a62657
to
708bce9
Compare
tzemanovic
changed the title
refactor token transfer
refactor token transfer and add more tests
Sep 13, 2024
tzemanovic
force-pushed
the
tomas/refactor-token-transfer
branch
from
September 14, 2024 16:26
708bce9
to
d138330
Compare
tzemanovic
force-pushed
the
tomas/refactor-token-transfer
branch
from
September 19, 2024 09:47
d138330
to
ec9e895
Compare
tzemanovic
force-pushed
the
tomas/refactor-token-transfer
branch
from
September 19, 2024 10:11
ec9e895
to
05cc8df
Compare
grarco
reviewed
Sep 19, 2024
tzemanovic
force-pushed
the
tomas/refactor-token-transfer
branch
from
September 20, 2024 12:48
05cc8df
to
c3cbda3
Compare
grarco
approved these changes
Sep 20, 2024
tzemanovic
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Moves the transfer code out of wasm into the token crates and adds more tests
Checklist before merging
breaking::
labels