Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic ledger managed tasks #3741

Merged
merged 9 commits into from
Sep 2, 2024
Merged

Dynamic ledger managed tasks #3741

merged 9 commits into from
Sep 2, 2024

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Sep 2, 2024

Describe your changes

Closes #459

Refactors the ledger boot-up code under run_aux, to support a dynamic number of managed tasks.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@sug0 sug0 added enhancement New feature or request ledger labels Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 70.03891% with 77 lines in your changes missing coverage. Please review.

Project coverage is 71.78%. Comparing base (9139dbe) to head (233378b).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/lib.rs 0.00% 39 Missing ⚠️
crates/node/src/ethereum_oracle/mod.rs 0.00% 25 Missing ⚠️
crates/node/src/abortable.rs 93.26% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3741      +/-   ##
==========================================
+ Coverage   71.66%   71.78%   +0.12%     
==========================================
  Files         311      311              
  Lines      101508   101658     +150     
==========================================
+ Hits        72748    72980     +232     
+ Misses      28760    28678      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sug0
Copy link
Contributor Author

sug0 commented Sep 2, 2024

I'll add a couple of tests to this branch before merging

@sug0 sug0 added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 2, 2024
@mergify mergify bot merged commit 5f20b23 into main Sep 2, 2024
22 of 23 checks passed
@mergify mergify bot deleted the tiago/run-aux-arbitrary-tasks branch September 2, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ledger merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_aux should be able to manage any arbitrary number of tasks
2 participants