-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic ledger managed tasks #3741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The abortable spawner then proceeds to await on all of these handles. There is a special pinned handle, that allows resuming unwinding upon encountering a panic on that task.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3741 +/- ##
==========================================
+ Coverage 71.66% 71.78% +0.12%
==========================================
Files 311 311
Lines 101508 101658 +150
==========================================
+ Hits 72748 72980 +232
+ Misses 28760 28678 -82 ☔ View full report in Codecov by Sentry. |
tzemanovic
reviewed
Sep 2, 2024
tzemanovic
approved these changes
Sep 2, 2024
I'll add a couple of tests to this branch before merging |
sug0
added
the
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
label
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
ledger
merge
Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #459
Refactors the ledger boot-up code under
run_aux
, to support a dynamic number of managed tasks.Checklist before merging
breaking::
labels