-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update storage gas cost #3746
Update storage gas cost #3746
Conversation
@yito88 The ibc e2e tests are failing because of gas, the costs are now slightly higher than before so we might need to update Hermes |
43d921f
to
876f78e
Compare
Actually, it seems like the only issue was a bug in the |
@@ -37,7 +37,7 @@ where | |||
let gas_scale = parameters::get_gas_scale(&state)?; | |||
|
|||
// Wrapper dry run to allow estimating the gas cost of a transaction | |||
let (wrapper_hash, extended_tx_result, tx_gas_meter) = | |||
let (wrapper_hash, extended_tx_result, tx_gas_meter, gas_used) = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modifications to this file are just temporary to fix a bug for which we were not tracking gas correctly. A better rework is provided in PR #3758 which is based on this one.
80325e2
to
d311278
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3746 +/- ##
=======================================
Coverage 72.41% 72.42%
=======================================
Files 335 335
Lines 104005 103993 -12
=======================================
- Hits 75320 75315 -5
+ Misses 28685 28678 -7 ☔ View full report in Codecov by Sentry. |
Describe your changes
Recovers the fix to the storage gas cost that was done in #3510 and went lost in #3554. Adjusts the
DEFAULT_GAS_LIMIT
and the gas limits in the genesis files.Also improves gas tracking for masp fee payment: the gas meter now does not account for the gas used up to that point (wrapper gas) which could prevent some txs that consume a lot of gas in that phase (e.g. batches) from successfully pay fees via the MASP.
Checklist before merging
breaking::
labels