Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dry run rebase #3781

Merged
merged 6 commits into from
Sep 8, 2024
Merged

Improve dry run rebase #3781

merged 6 commits into from
Sep 8, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Sep 8, 2024

Describe your changes

Reiterates on #3758 which was not merged successfully.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@grarco grarco marked this pull request as ready for review September 8, 2024 13:35
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.69%. Comparing base (59fdda8) to head (1646626).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/governance/src/vp/mod.rs 0.00% 1 Missing ⚠️
crates/node/src/dry_run_tx.rs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3781      +/-   ##
==========================================
- Coverage   72.69%   72.69%   -0.01%     
==========================================
  Files         338      338              
  Lines      104324   104299      -25     
==========================================
- Hits        75839    75817      -22     
+ Misses      28485    28482       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 8, 2024
@mergify mergify bot merged commit 7cbc10a into main Sep 8, 2024
24 of 36 checks passed
@mergify mergify bot deleted the grarco/improve-dry-run-2-rebase branch September 8, 2024 14:38
@grarco grarco mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants