Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Murisi/integrate hw masp #3797

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Murisi/integrate hw masp #3797

wants to merge 11 commits into from

Commits on Oct 29, 2024

  1. Implemented MASP signing using the hardware wallet.

    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    045d18c View commit details
    Browse the repository at this point in the history

  2. Factored out the logic for MASP hardware wallet signing.

    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e665012 View commit details
    Browse the repository at this point in the history

  3. Expand MASP hardware wallet support to other transaction types.

    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    abd4199 View commit details
    Browse the repository at this point in the history

  4. Separate the storage of shielded keys from their birthdays.

    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ca4132d View commit details
    Browse the repository at this point in the history

  5. Never use the hardware wallet to sign the fee header alone. Always en… 

    …sure removal of MASP Builder data.
    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3ce8347 View commit details
    Browse the repository at this point in the history

  6. Moved the shielded keys used in the integration tests into the localn… 

    …et wallet.
    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f7b83e5 View commit details
    Browse the repository at this point in the history

  7. Dont do a dry run if using a device in the MASP integration tests.

    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c85981c View commit details
    Browse the repository at this point in the history

  8. Always sign MASP Transactions before dumping because randomness param… 

    …eters cannot be reused. Fixed MASP integration tests depending on access to secret keys.
    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2d9206c View commit details
    Browse the repository at this point in the history

  9. test/e2e/masp: add support for testing with HW wallet

    @tzemanovic @murisi
    tzemanovic authored and murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7748a05 View commit details
    Browse the repository at this point in the history

  10. Sometimes use literals instead of aliases in the IBC tests.

    @murisi
    murisi committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a9c37da View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Make shielded balance checking more robust for IBC tests.

    @murisi
    murisi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    23fba46 View commit details
    Browse the repository at this point in the history