Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better conversions debugging #3805

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Better conversions debugging #3805

merged 3 commits into from
Sep 11, 2024

Conversation

brentstone
Copy link
Collaborator

Describe your changes

Closes #3803

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

@brentstone brentstone marked this pull request as draft September 11, 2024 08:47
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.70%. Comparing base (39c940d) to head (28cde22).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3805   +/-   ##
=======================================
  Coverage   72.69%   72.70%           
=======================================
  Files         338      338           
  Lines      104467   104467           
=======================================
+ Hits        75946    75950    +4     
+ Misses      28521    28517    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/better-conversions-logging branch from a5779b1 to 28cde22 Compare September 11, 2024 09:20
@brentstone brentstone marked this pull request as ready for review September 11, 2024 09:20
@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 11, 2024
@mergify mergify bot merged commit d32e856 into main Sep 11, 2024
25 of 38 checks passed
@mergify mergify bot deleted the brent/better-conversions-logging branch September 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix this stupid conversions log
2 participants