Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate annual staking rewards rate #3816

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Sep 13, 2024

Describe your changes

Closes #3817

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@brentstone brentstone force-pushed the brent/estimate-staking-reward-rate branch 2 times, most recently from 3d889d1 to beca1be Compare September 13, 2024 19:03
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 94.05941% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.80%. Comparing base (f7830f6) to head (8c4e722).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/rpc.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3816      +/-   ##
==========================================
+ Coverage   72.78%   72.80%   +0.02%     
==========================================
  Files         338      338              
  Lines      103923   103995      +72     
==========================================
+ Hits        75637    75711      +74     
+ Misses      28286    28284       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/estimate-staking-reward-rate branch from beca1be to d979482 Compare September 14, 2024 13:15
@brentstone brentstone marked this pull request as ready for review September 14, 2024 13:15
@brentstone brentstone force-pushed the brent/estimate-staking-reward-rate branch from d979482 to 68c1dde Compare September 15, 2024 15:08
@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 15, 2024
Copy link
Contributor

mergify bot commented Sep 15, 2024

Hey @brentstone, your pull request has been dequeued due to the following reason: PR_DEQUEUED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@mergify mergify bot merged commit e603759 into main Sep 15, 2024
22 checks passed
@mergify mergify bot deleted the brent/estimate-staking-reward-rate branch September 15, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple query to obtain an estimate of the latest annual staking reward rate
2 participants