-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify MASP refs events #3821
Unify MASP refs events #3821
Conversation
ed4b235
to
dc83608
Compare
2eb896c
to
8bdc492
Compare
8bdc492
to
2659efd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3821 +/- ##
==========================================
+ Coverage 72.79% 72.80% +0.01%
==========================================
Files 338 338
Lines 103995 103989 -6
==========================================
+ Hits 75701 75708 +7
+ Misses 28294 28281 -13 ☔ View full report in Codecov by Sentry. |
Make an issue for better way to emit MASP ref event (in your TODO)? |
Done with #3824 |
Describe your changes
Unifies the previous two masp refs events into a single
MaspTxBatchRefs
event: this ensures that no reordering of masp data can happen on the client side that would lead to the construction of an invalid state.Updates the
IndexedTx
type to carry an optional pointer to a specific inner tx inside a batch. This fixes an issue for which the shielded sync command could not properly process multiple masp transactions in a same batch: it was appending the decrypted tx to a map using as an index the same block height and tx index, effectively taking into account only the last masp transaction of a batchTODOs:
See if there's a better way to emit the masp ref event (maybe without the need for(Reduce masp events #3824 )ExtendedTxResult
)Update the indexerChecklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo