Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masp tests #3840

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Masp tests #3840

merged 9 commits into from
Oct 14, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Sep 23, 2024

Describe your changes

Partially addresses #3836.
Partially addresses #3828.

Adds more integration test for the MASP including some tests with tx batches.
Adds some protests for the MASP vp.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.25%. Comparing base (a98a2ec) to head (16f3bb9).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3840      +/-   ##
==========================================
+ Coverage   73.21%   73.25%   +0.03%     
==========================================
  Files         341      341              
  Lines      105280   105334      +54     
==========================================
+ Hits        77081    77158      +77     
+ Misses      28199    28176      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

grarco added a commit that referenced this pull request Sep 26, 2024
@grarco grarco marked this pull request as ready for review September 26, 2024 14:33
@grarco grarco changed the title More masp tests Masp tests Sep 26, 2024
crates/shielded_token/src/vp.rs Show resolved Hide resolved
],
)?;
node.assert_success();
let file_path = tempdir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you love to see it

crates/tests/src/integration/masp.rs Outdated Show resolved Hide resolved
crates/tests/src/integration/masp.rs Outdated Show resolved Hide resolved
@grarco grarco mentioned this pull request Sep 27, 2024
14 tasks
@grarco grarco added merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass backport-44 labels Oct 14, 2024
@mergify mergify bot merged commit 81467ed into main Oct 14, 2024
24 checks passed
@mergify mergify bot deleted the grarco/masp-tests branch October 14, 2024 11:52
mergify bot pushed a commit that referenced this pull request Oct 14, 2024
(cherry picked from commit 550c623)
@mergify mergify bot mentioned this pull request Oct 14, 2024
3 tasks
mergify bot added a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-44 merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants