Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: Fix clap panic on parsing relayer commands #3841

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

batconjurer
Copy link
Member

Describe your changes

Currently, the binaries panic on trying to parse commands pertaining to the relayer binary. This fixes that.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.02%. Comparing base (760462b) to head (6daffe4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3841   +/-   ##
=======================================
  Coverage   73.01%   73.02%           
=======================================
  Files         340      340           
  Lines      104750   104750           
=======================================
+ Hits        76488    76489    +1     
+ Misses      28262    28261    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Sep 24, 2024
@mergify mergify bot merged commit 7d27981 into main Sep 24, 2024
23 of 24 checks passed
@mergify mergify bot deleted the bat/fix/clap-cheeks branch September 24, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants