-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serde rename batch index into masp tx index #3860
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3860 +/- ##
=======================================
Coverage 73.24% 73.24%
=======================================
Files 341 341
Lines 105240 105240
=======================================
+ Hits 77085 77088 +3
+ Misses 28155 28152 -3 ☔ View full report in Codecov by Sentry. |
Hey @mateuszjasiuk, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Hey @mateuszjasiuk, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
it looks like this a breaking change for IBC (possibly in hermes) as it keeps failing in |
@tzemanovic hm that's odd. I'm not sure if that issue is specific to this PR, since ibc upgrade client doesn't have anything to do with the masp |
Whats the status here? I'd like to cut 0.45.0 very soon, and my latest understanding is that this should be included. @Fraccaman |
4093f0b
to
b2bdee6
Compare
(cherry picked from commit b2bdee6)
feat: serde rename batch index into masp tx index (backport #3860)
* 0.44.0: Namada 0.44.1 Removes old reference to encrypted txs test/e2e/ibc: try to kill gaiad before running it Fixes broken assertions in integration tests Update crates/sdk/src/queries/vp/pos.rs small fix from comments changelog: add #3899 fix up liveness queries Add new rpc query function to check validators' liveness(uptime) in this epoch test/e2e: try to forward Ctrl+C to the bg session Changelog for #3860 feat: serde rename batch index into masp tx index Tries to drop bg process in tests mergify: unquote base branch name Changelog #3882 Extends batch sections test to check duplicate sections Custom `PartialEq` impl for `SigningTxData` Fixes cmt reference in `add_inner_tx` Avoids duplicated sections when contructing a batch ci/mergify: unquote base name Increases timeout on epoch sleep Improves epoch sleeping in ibc tests and renames token variable Changelog #3866 Sped up ibc token test Fixes ibc gas payment test Fixes typos and updates docstring e2e test for ibc token gas payment goveranance: let validator vote even if it doesn't have a self-bond changelog: add #3835 tx: test tx sections api tx: improve the serialization api test/tx: add more unit tests tx: split out tx sections into dedicated mod tx: move signing related code into sign mod tx: rm unsued `SignedTxData` refactor and test signature index tx/types: rm unused code test/e2e: no dbg logs in shielded sync ci/mergify: add merge rule for backport to 0.44 mergify: add backport strategy Changelog #3857 Removes unused `Success` event Adds test for identical events in batch Adds batch events tests Removes eprintln from prepare proposal unit tests Adds tests for whitelisted tokens gas payment update hermes test/e2e: increase hermes timeout README: add notes about hermes update hermes ci: run checks on release branches
Describe your changes
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo