Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

governance: let validator vote even if it doesn't have a self-bond #3874

Merged
merged 1 commit into from
Oct 3, 2024
Merged

governance: let validator vote even if it doesn't have a self-bond #3874

merged 1 commit into from
Oct 3, 2024

Conversation

Fraccaman
Copy link
Member

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@Fraccaman Fraccaman requested review from brentstone, tzemanovic and grarco and removed request for brentstone and tzemanovic October 2, 2024 17:48
@Fraccaman Fraccaman changed the title goveranance: let validator vote even if it doesn't have a self-bond governance: let validator vote even if it doesn't have a self-bond Oct 2, 2024
brentstone
brentstone approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for catching this

@tzemanovic tzemanovic added merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass backport-44 labels Oct 3, 2024
@tzemanovic
Copy link
Member

we should have some test(s) covering this

mergify bot added a commit that referenced this pull request Oct 3, 2024
@mergify
Merge of #3874
4cd8c1c
@mergify mergify bot mentioned this pull request Oct 3, 2024
Closed
@mergify mergify bot merged commit 602d154 into main Oct 3, 2024
21 of 22 checks passed
@mergify mergify bot deleted the fraccaman/fix-voting-self-bond branch October 3, 2024 09:20
@mergify mergify bot mentioned this pull request Oct 3, 2024
Merged
3 tasks
@McDaan
Copy link
Contributor

McDaan commented Oct 11, 2024

thx for catching this

Actually, it's been catched due to our report. I'm surprised that's even not mention to the issue before merging.

#3859

@brentstone brentstone mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grarco grarco grarco approved these changes

@brentstone brentstone brentstone approved these changes

@tzemanovic tzemanovic tzemanovic approved these changes

Assignees
No one assigned
Labels
backport-44 merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fraccaman @tzemanovic @McDaan @brentstone @grarco