Attempt to kill bg process in tests (backport #3894) #3898
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Some e2e tests rely on background processes, especially the IBC ones with
hermes
andgaiad
. There are cases in which the test fails and some of these tasks (especiallygaiad
) are not affected by the crash of the Namada node. In this case the runtime drops theNamadaBgCmd
but unfortunately dropping aJoinHandle
only detaches the target task. This is undesired cause if we run the test again the conflicting instances of the background process will cause another test failure.This PR attempts to run some cleanup code when dropping
NamadaBgCmd
to kill the task.Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repoThis is an automatic backport of pull request #3894 done by [Mergify](https://mergify.com).