Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to kill bg process in tests (backport #3894) #3898

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

Describe your changes

Some e2e tests rely on background processes, especially the IBC ones with hermes and gaiad. There are cases in which the test fails and some of these tasks (especially gaiad) are not affected by the crash of the Namada node. In this case the runtime drops the NamadaBgCmd but unfortunately dropping a JoinHandle only detaches the target task. This is undesired cause if we run the test again the conflicting instances of the background process will cause another test failure.

This PR attempts to run some cleanup code when dropping NamadaBgCmd to kill the task.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #3894 done by [Mergify](https://mergify.com).

(cherry picked from commit 1773a17)
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (328540c) to head (b0dc34a).
Report is 2 commits behind head on 0.44.0.

Additional details and impacted files
@@            Coverage Diff             @@
##           0.44.0    #3898      +/-   ##
==========================================
- Coverage   73.25%   73.24%   -0.02%     
==========================================
  Files         341      341              
  Lines      105241   105241              
==========================================
- Hits        77098    77086      -12     
- Misses      28143    28155      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 10, 2024
@grarco grarco self-requested a review October 10, 2024 15:42
@mergify mergify bot merged commit ea7e418 into 0.44.0 Oct 10, 2024
22 of 24 checks passed
@mergify mergify bot deleted the mergify/bp/0.44.0/pr-3894 branch October 10, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant