Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests assertions (backport #3902) #3913

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 11, 2024

Describe your changes

Updates assert_success in integration tests to avoid ignoring missing results.
Fixes wrong usage of the same function in conjunction with Client commands that don't modify the auxiliary fields of InnerMockNode.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #3902 done by [Mergify](https://mergify.com).

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 11, 2024
mergify bot added a commit that referenced this pull request Oct 11, 2024
@mergify mergify bot merged commit b5168e6 into 0.44.0 Oct 11, 2024
20 of 21 checks passed
@mergify mergify bot deleted the mergify/bp/0.44.0/pr-3902 branch October 11, 2024 09:45
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.22%. Comparing base (fc9021a) to head (7a2e3c8).
Report is 5 commits behind head on 0.44.0.

Additional details and impacted files
@@           Coverage Diff           @@
##           0.44.0    #3913   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         341      341           
  Lines      105281   105281           
=======================================
  Hits        77088    77088           
  Misses      28193    28193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants