Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more info to gas errors #4004

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

batconjurer
Copy link
Member

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.89%. Comparing base (9a06dae) to head (3b6ce2c).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/protocol.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4004   +/-   ##
=======================================
  Coverage   73.88%   73.89%           
=======================================
  Files         341      341           
  Lines      106463   106469    +6     
=======================================
+ Hits        78663    78678   +15     
+ Misses      27800    27791    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/gas/src/lib.rs Outdated Show resolved Hide resolved
crates/node/src/protocol.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 14, 2024
mergify bot added a commit that referenced this pull request Nov 14, 2024
@mergify mergify bot merged commit 85a59cf into main Nov 14, 2024
23 of 24 checks passed
@mergify mergify bot deleted the bat/gas-failure-error-improvements branch November 14, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants