Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixups learned from dry-run #4021

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixups learned from dry-run #4021

wants to merge 3 commits into from

Conversation

brentstone
Copy link
Collaborator

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.08%. Comparing base (e768857) to head (3bb5a02).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
crates/proof_of_stake/src/rewards.rs 50.00% 4 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4021      +/-   ##
==========================================
- Coverage   74.09%   74.08%   -0.01%     
==========================================
  Files         341      341              
  Lines      107204   107213       +9     
==========================================
+ Hits        79428    79432       +4     
- Misses      27776    27781       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone added this to the v0.46.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when quering for staking rewards in epoch 0
1 participant