Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/re enable masp hw support #4219

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

murisi
Copy link
Collaborator

@murisi murisi commented Jan 6, 2025

Describe your changes

Enable MASP hardware wallet support by reverting the reversion (bec57d6) enacted in #4127 . Hence this PR is essentially the same as #3797 . For clarity, this PR makes the following changes:

  • Allow the outsourcing of generator randomness to the hardware wallet
  • Allow the generation of MASP extended full viewing keys using the hardware wallet
  • Allow the client to generate proofs using proof generation keys from the hardware wallet
  • Now apply signatures generated by the hardware wallet onto client build Transactions
  • The following transaction types are supported by MASP hardware wallet signing:
    • Shielding transactions (only randomness parameters are taken from hardware wallet)
    • Shielded, unshielding, and IBC transactions (randomness parameters and proof generation keys are taken from hardware wallet)
    • Combined hardware wallet and software client signing where the the shielded keys are on the hardware wallet and wrapper signer keys are on the computer, or vice-versa, or both reside on the device is supported
  • Upgraded the ledger-namada-rs dependency to the v2.0.2 release from Zondax. (The private fork at https://github.com/heliaxdev/ledger-namada/tree/murisi/zip32-support is no longer required.)

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

murisi added 2 commits January 6, 2025 16:20
…ges when MASP hardware wallet integration functionality is triggered."

This reverts commit bec57d6.
@brentstone brentstone added this to the v1.1.0 milestone Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.63%. Comparing base (b579d49) to head (c51b1af).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4219   +/-   ##
=======================================
  Coverage   74.62%   74.63%           
=======================================
  Files         342      342           
  Lines      108554   108554           
=======================================
+ Hits        81009    81015    +6     
+ Misses      27545    27539    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi added the MASP label Jan 6, 2025
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 7, 2025
mergify bot added a commit that referenced this pull request Jan 7, 2025
@mergify mergify bot merged commit fbf6c87 into main Jan 7, 2025
24 of 25 checks passed
@mergify mergify bot deleted the murisi/re-enable-masp-hw-support branch January 7, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants