Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W6M3 - Updates and Maintenance 01/05/24 #231

Merged
merged 5 commits into from
May 13, 2024

Conversation

jonbrenas
Copy link
Collaborator

Addresses #193 for this module.
Addresses #199 for this module.
Addresses #224 for this module.

Resolves #223 (temporarily). I actually removed all warnings to avoid the pandas and bokeh warnings as well. There is a note saying "Note: you may need to restart the kernel to use updated packages." that I am not found of but I can't get rid of.

@jonbrenas jonbrenas changed the title W6M3 Updates and Maintenance 01/05/24 W6M3 - Updates and Maintenance 01/05/24 May 1, 2024
@jonbrenas jonbrenas requested review from alimanfoo, cclarkson and ahernank and removed request for alimanfoo, cclarkson and ahernank May 1, 2024 14:43
@jonbrenas
Copy link
Collaborator Author

#233 needs to be addressed before reviews so I have suspended the request.

@jonbrenas
Copy link
Collaborator Author

The links to the figures have been corrected.

Copy link
Collaborator

@ahernank ahernank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonbrenas! Very minor, the link on paper for For a deeper dive in the statistic and it's underlying mathematics, I would highly recommend the Garud lab website or for the brave, the paper. has a leading https, so it is not redirecting correctly; it also seems that the image below didn't fully render but this might just be the view here and suspect the HTML looked fine when building.

@ahernank
Copy link
Collaborator

Thanks @jonbrenas, we are just missing the small URL typo above & we should be able to merge.

@ahernank ahernank merged commit fecadc7 into master May 13, 2024
1 check passed
@ahernank ahernank deleted the w6m3-updates-and-maintenance branch May 13, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants