Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include python3.13 and fix pyright Windows issue in CI #19

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Include python3.13 and fix pyright Windows issue in CI #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d76194
Constrain pyright version for Windows, for now
yanovs Oct 26, 2024
95150ea
Include python3.13
yanovs Oct 26, 2024
1113291
Skip integration tests in 3.13
yanovs Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
# TODO: Switch back to `macos-latest` when we fix small issues with macOS 14 ARM
- macos-13
- windows-latest
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.8']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13', 'pypy-3.8']
exclude:
# It looks like the issue with with macos-13/python3.8 is that the
# GitHub image for macos-13 switched from gcc 11 to 12, and this makes
Expand Down Expand Up @@ -71,11 +71,12 @@ jobs:

- name: Integration test with nox
run: nox -t integration_test --python ${{ matrix.python-version }}
# Skip integration tests on Windows/py3.8 because
# there are no pre-built Windows/py3.8/numpy1.6.6 wheels.
# Skip py3.9 because none of the bundles are for it.
# TODO: Investigate issues on Windows and pypy.
if: ${{ (matrix.python-version != '3.9') && ! (matrix.os == 'windows-latest' && matrix.python-version == '3.8') && ! startsWith(matrix.python-version, 'pypy-') }}
# Notes:
# - Skip py3.9 and py3.13 because none of the bundles are for it.
# - Skip integration tests on Windows/py3.8 because
# there are no pre-built Windows/py3.8/numpy1.6.6 wheels.
# - TODO: Investigate issues on Windows and pypy.
if: ${{ (matrix.python-version != '3.9') && (matrix.python-version != '3.13') && ! (matrix.os == 'windows-latest' && matrix.python-version == '3.8') && ! startsWith(matrix.python-version, 'pypy-') }}

- name: Upload failed outputs
uses: actions/upload-artifact@v4
Expand Down
6 changes: 6 additions & 0 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ def mypy(session: nox.Session) -> None:

@nox.session(tags=["static", "typecheck"])
def pyright(session: nox.Session) -> None:
# TODO: Remove once pyright >= 1.1.387 is available. See:
# - https://github.com/microsoft/pyright/issues/9296
# - https://docs.python.org/3/library/sys.html#sys.platform
if sys.platform == "win32":
session.install("pyright <= 1.1.385")

if is_isolated_venv(session):
session.install("-e", ".[test]")

Expand Down
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ classifiers =
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
Programming Language :: Python :: 3.13
Programming Language :: Python :: Implementation :: CPython
Programming Language :: Python :: Implementation :: PyPy
Topic :: Software Development :: Libraries
Expand Down