Update parser_and_mv to Remove A1 Reading and Use schemas.yaml #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issam71100
pushed a commit
that referenced
this pull request
Dec 23, 2024
issam71100
force-pushed
the
feature/parser/remove-a1-cell-dependence
branch
from
4382fd8 to
768f151
Compare
issam71100
pushed a commit
that referenced
this pull request
Dec 23, 2024
issam71100
force-pushed
the
feature/parser/remove-a1-cell-dependence
branch
from
768f151 to
9b0baf4
Compare
issam71100
added
the
Review Ready
romainfd
approved these changes
Dec 23, 2024
Comment on lines
188
to
192
| commit_options: '--no-verify' | ||
| file_pattern: | | ||
| csv_parser/json_schema2xsd/src/main/resources/schemas.yaml | ||
| csv_parser/out/**/*.docx | ||
| csv_parser/out/**/*.pdf |
There was a problem hiding this comment.
J'avais une erreur dans la pipeline, le commit push ne fonctionnais pas car certains fichier allait être écrasé lors du changement de branche. J'ai donc rajouté ces 2 options me permettant d'ignorée ces fichiers.
There was a problem hiding this comment.
Mais on veut le garder ?
There was a problem hiding this comment.
D'accord, je vais modifier la pipeline pour rajouter ces fichiers dans le commit alors
issam71100
force-pushed
the
feature/parser/remove-a1-cell-dependence
branch
from
29d0351 to
b58fc6b
Compare
|
|
Fermée pour reprise par #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the parser_and_mv script to eliminate the dependency on reading from cell A1. Instead, it directly utilizes the already generated schemas.yaml file, incorporating the filename and sheet name.