Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Various parser features #31

Merged

Conversation

saveliy-sviridov
Copy link
Contributor

  1. Ajout de title et description au niveau des $refs
  2. Ajout de cardinalité pour les arrays 1 .. (x)

Copy link

github-actions bot commented Feb 1, 2024

File Coverage [27.03%]
AdditionalInformation.java 36.94%
AdditionalInformation.java 17.12%
Total Project Coverage 64.64% 🍏

@saveliy-sviridov saveliy-sviridov changed the title WIP: Feat/Various parser features Feat/Various parser features Feb 2, 2024
@romainfd romainfd changed the base branch from main to auto/model_tracker February 13, 2024 15:18
@romainfd romainfd changed the base branch from auto/model_tracker to main February 13, 2024 15:18
Copy link
Collaborator

@romainfd romainfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far, waiting for the action to be triggered again so that schemas are re-generated without the title/description in the objects

@@ -289,7 +289,7 @@ strict digraph {
</TR>
<TR><TD BORDER="0"><I>objet customMap</I></TD></TR><TR><TD BORDER="0" >key <I>string</I> : [1..1] </TD></TR><TR><TD BORDER="0" >label <I>string</I> : [0..1] </TD></TR><TR><TD BORDER="0" >value <I>string</I> : [1..1] </TD></TR><TR><TD BORDER="0" >freetext <I>string</I> : [0..1] </TD></TR>
</TABLE>>]
customMap -> additionalInformation [constraint=true headlabel=1 taillabel="0..1"]
customMap -> additionalInformation [constraint=true headlabel=1 taillabel="0..*"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A corriger !

@@ -541,7 +541,7 @@ strict digraph {
</TR>
<TR><TD BORDER="0"><I>objet customMap</I></TD></TR><TR><TD BORDER="0" >key <I>string</I> : [1..1] </TD></TR><TR><TD BORDER="0" >label <I>string</I> : [0..1] </TD></TR><TR><TD BORDER="0" >value <I>string</I> : [1..1] </TD></TR><TR><TD BORDER="0" >freetext <I>string</I> : [0..1] </TD></TR>
</TABLE>>]
customMap -> additionalInformation [constraint=true headlabel=1 taillabel="0..1"]
customMap -> additionalInformation [constraint=true headlabel=1 taillabel="0..*"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

saveliy-sviridov and others added 3 commits February 13, 2024 16:52
…scription-into-object-instead-of-definitions

# Conflicts:
#	csv_parser/csv_parser.py
#	csv_parser/json_schema2xsd/src/main/resources/EMSI.schema.json
#	csv_parser/json_schema2xsd/src/main/resources/RC-EDA.schema.json
#	csv_parser/json_schema2xsd/src/main/resources/RS-EDA.schema.json
#	csv_parser/out/EMSI/EMSI.schema.docx
#	csv_parser/out/EMSI/EMSI.uml_diagram.pdf
#	csv_parser/out/RC-EDA/RC-EDA.schema.docx
#	csv_parser/out/RC-EDA/RC-EDA.uml_diagram.pdf
#	csv_parser/out/RS-EDA/RS-EDA.schema.docx
#	csv_parser/out/RS-EDA/RS-EDA.uml_diagram.pdf
#	csv_parser/out/hubsante.asyncapi.yaml
#	src/main/resources/json-schema/EMSI.schema.json
#	src/main/resources/json-schema/RC-EDA.schema.json
#	src/main/resources/json-schema/RS-EDA.schema.json
…nto-object-instead-of-definitions' into feat/put-title-and-description-into-object-instead-of-definitions
Copy link

File Coverage [27.03%]
AdditionalInformation.java 36.94%
AdditionalInformation.java 17.12%
Total Project Coverage 64.64% 🍏

Copy link
Collaborator

@romainfd romainfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@romainfd romainfd merged commit 6f64fb2 into main Feb 13, 2024
@romainfd romainfd deleted the feat/put-title-and-description-into-object-instead-of-definitions branch February 13, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants