Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1663/82162752 backport][stable-5] Allow user to associate rds cluster with a global rds cluster #1664

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 26, 2023

This is a backport of PR #1663 as merged into main (8216275).

SUMMARY

Allow user to associate rds cluster with a global rds cluster

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_cluster

ADDITIONAL INFORMATION

…ing GlobalClusterIdentifier (#1663)

Allow user to associate rds cluster with a global rds cluster

SUMMARY

Allow user to associate rds cluster with a global rds cluster

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

rds_cluster
ADDITIONAL INFORMATION

Reviewed-by: Jill R
Reviewed-by: Mandar Kulkarni <[email protected]>
(cherry picked from commit 8216275)
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Jul 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2f3b2048a2794d4eb785533a85dd2a86

✔️ ansible-galaxy-importer SUCCESS in 7m 17s
✔️ build-ansible-collection SUCCESS in 12m 58s
✔️ ansible-test-splitter SUCCESS in 5m 16s
integration-amazon.aws-1 FAILURE in 7m 22s
Skipped 43 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Jul 26, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/17d6b9699e6046c5915c898cf2e9d776

✔️ ansible-galaxy-importer SUCCESS in 5m 38s
✔️ build-ansible-collection SUCCESS in 12m 48s
✔️ ansible-test-splitter SUCCESS in 5m 18s
integration-amazon.aws-1 FAILURE in 8m 25s
Skipped 43 jobs

@hakbailey hakbailey added this to the 5.5.3 milestone Jul 27, 2023
@gravesm
Copy link
Member

gravesm commented Jul 28, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/d5f882ecf66143319fd31f37b18a420c

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 12m 32s
✔️ ansible-test-splitter SUCCESS in 4m 59s
integration-amazon.aws-1 FAILURE in 9m 20s
Skipped 43 jobs

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 31, 2023
Fix rds_cluster tests on stable-5 branch

SUMMARY

This fixes two problems with the rds_cluster test target. Ansible 2.16 is removing ansible.builtin.include (and has removed it in the current milestone branch), so this has been replaced with ansible.builtin.include_tasks. In addition, this updates the engine as Aurora 1 has been retired.
I'm a little confused by the history of this test target. #1493 and #1504 seem to have been merged on the same day, with one overwriting some of the changes of the other. The tests for rds_cluster on the stable-5 branch are currently broken, though, as can be seen in the failure on #1664. If there's a better way to fix this, feel free to suggest something different.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Jill R
Reviewed-by: Alina Buzachis
@alinabuzachis
Copy link
Contributor

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/3e25f2d16a7b4b99a79602d3355a15bb

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 13m 43s
✔️ ansible-test-splitter SUCCESS in 4m 43s
integration-amazon.aws-1 RETRY_LIMIT in 1m 29s
Skipped 43 jobs

@alinabuzachis
Copy link
Contributor

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/1660083453d5450187cf5079315d8751

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 13m 09s
✔️ ansible-test-splitter SUCCESS in 5m 03s
✔️ integration-amazon.aws-1 SUCCESS in 15m 57s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7f932c6 into stable-5 Jul 31, 2023
85 of 118 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/82162752ed79c810e16e0801a14b2126e3b6506b/pr-1663 branch July 31, 2023 12:20
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
aws_ssm - Refactor _file_transport_command

Depends-On: ansible/ansible-zuul-jobs#1748
Depends-On: ansible-collections#1663
SUMMARY
Yet more cleanup of aws_ssm
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants