Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1670/31c75069 backport][stable-6] Default filters to empty dictionary #1678

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[PR #1670/31c75069 backport][stable-6] Default filters to empty dictionary #1678

merged 1 commit into from
Aug 1, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 1, 2023

This is a backport of PR #1670 as merged into main (31c7506).

SUMMARY

Changes the default for the filters option from None to an empty dictionary.

Fixes: #1668

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vpc_route_table_info

ADDITIONAL INFORMATION

This matches what other *info modules (e.g. ec2_vpc_endpoint_info or ec2_vpc_subnet_info) do for the filters option default.

@branic @patchback
Default filters to empty dictionary (#1670)
50c5a71 
Default filters to empty dictionary

SUMMARY

Changes the default for the filters option from None to an empty dictionary.

Fixes: #1668
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_vpc_route_table_info
ADDITIONAL INFORMATION

This matches what other *info modules (e.g. ec2_vpc_endpoint_info or ec2_vpc_subnet_info) do for the filters option default.

Reviewed-by: Alina Buzachis
Reviewed-by: Brant Evans <[email protected]>
Reviewed-by: Mark Chappell
Reviewed-by: Mike Graves <[email protected]>
(cherry picked from commit 31c7506)
@patchback patchback bot mentioned this pull request Aug 1, 2023
Merged
@github-actions
Copy link

github-actions bot commented Aug 1, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

cc @jillr @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Aug 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/67c272ac55a141bd8bed519b69e181e3

✔️ ansible-galaxy-importer SUCCESS in 5m 41s
✔️ build-ansible-collection SUCCESS in 14m 11s
✔️ ansible-test-splitter SUCCESS in 5m 32s
✔️ integration-amazon.aws-1 SUCCESS in 19m 15s
Skipped 43 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Aug 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b17f813c3c5e409ab579833c9353c8ea

✔️ ansible-galaxy-importer SUCCESS in 5m 19s
✔️ build-ansible-collection SUCCESS in 13m 45s
✔️ ansible-test-splitter SUCCESS in 5m 37s
✔️ integration-amazon.aws-1 SUCCESS in 19m 15s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 87b860a into stable-6 Aug 1, 2023
91 of 177 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-6/31c750691949b2271324eef187928680a2ee3888/pr-1670 branch August 1, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @alinabuzachis @branic