Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1683/983cbe90 backport][stable-6] route53: add wait_id return value in case of changes #1686

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 2, 2023

This is a backport of PR #1683 as merged into main (983cbe9).

SUMMARY

This allows to wait for changes later on when wait=false is provided to the module.

Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :)

(I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

route53

route53: add wait_id return value in case of changes

SUMMARY
This allows to wait for changes later on when wait=false is provided to the module.
Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :)
(I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.)
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
route53

Reviewed-by: Mark Chappell
(cherry picked from commit 983cbe9)
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f769035127e74640a0f79eaed4c9609f

✔️ ansible-galaxy-importer SUCCESS in 5m 22s
✔️ build-ansible-collection SUCCESS in 13m 42s
✔️ ansible-test-splitter SUCCESS in 5m 03s
✔️ integration-amazon.aws-1 SUCCESS in 8m 48s
Skipped 43 jobs

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Aug 2, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/15a0fac8aaeb475982eb350787c50a97

✔️ ansible-galaxy-importer SUCCESS in 5m 04s
✔️ build-ansible-collection SUCCESS in 13m 10s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-amazon.aws-1 SUCCESS in 9m 24s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 523c1ff into stable-6 Aug 2, 2023
65 of 92 checks passed
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-6/983cbe90f0d5b990ae8110b0717b50c36b4a1d76/pr-1683 branch August 2, 2023 21:08
@felixfontein
Copy link
Contributor

@alinabuzachis thanks!

abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Fix copying of empty file

SUMMARY
Fixes ansible-collections#1686.
Basically it is a workaround for curl, which did not create empty files when using the -o flag (curl/curl#183). Although this issue was fixed in 2015, 'actively maintained operating systems' still use older of it (e.g. CentOS 7)
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
I was not able to test it yet in a relevant environment (e.g. with CentOS 7), will do so shortly.

Reviewed-by: Bence Hornák <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants