-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #1683/983cbe90 backport][stable-6] route53: add wait_id return value in case of changes #1686
Conversation
route53: add wait_id return value in case of changes SUMMARY This allows to wait for changes later on when wait=false is provided to the module. Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :) (I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update version_added and the backport-5 label needs to be removed.) ISSUE TYPE Feature Pull Request COMPONENT NAME route53 Reviewed-by: Mark Chappell (cherry picked from commit 983cbe9)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 22s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 04s |
523c1ff
into
stable-6
@alinabuzachis thanks! |
Fix copying of empty file SUMMARY Fixes ansible-collections#1686. Basically it is a workaround for curl, which did not create empty files when using the -o flag (curl/curl#183). Although this issue was fixed in 2015, 'actively maintained operating systems' still use older of it (e.g. CentOS 7) ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION I was not able to test it yet in a relevant environment (e.g. with CentOS 7), will do so shortly. Reviewed-by: Bence Hornák <None> Reviewed-by: Mark Chappell <None>
This is a backport of PR #1683 as merged into main (983cbe9).
SUMMARY
This allows to wait for changes later on when
wait=false
is provided to the module.Will be needed for a new route53_wait module I'll create a PR for soon in community.aws :)
(I'm not sure whether another 5.x.0 feature release is planned; in case it is not I'll update
version_added
and thebackport-5
label needs to be removed.)ISSUE TYPE
COMPONENT NAME
route53