[PR #1768/d1c5f053 backport][stable-6] elb_application_lb_info - ensure queries for additional ALB data have retries enabled #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
… retries enabled (#1768) elb_application_lb_info - ensure queries for additional ALB data have retries enabled SUMMARY As per #1767 the queries to pull extra info about ALBs are hitting rate limits when there's a lot of ALBs. Unfortunately the initial list operation has limited server-side filtering capabilities (and we don't have consistent client side filtering implemented at this time). Ensure that all of the extra queries have retries with jittered backoff enabled. Additionally, drops a redundant describe_load_balancers call to retrieve the ip_address_type information. (added by ansible-collections/community.aws#499) ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION I don't consider this a full fix for #1767 so I'm not using the "fixes". Reviewed-by: Alina Buzachis (cherry picked from commit d1c5f05)
tremble
approved these changes
Sep 27, 2023
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 58s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 23s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-6/d1c5f053293e6e143fbff384ad081d1794df84fa/pr-1768
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1768 as merged into main (d1c5f05).
SUMMARY
As per #1767 the queries to pull extra info about ALBs are hitting rate limits when there's a lot of ALBs. Unfortunately the initial list operation has limited server-side filtering capabilities (and we don't have consistent client side filtering implemented at this time).
Ensure that all of the extra queries have retries with jittered backoff enabled.
Additionally, drops a redundant describe_load_balancers call to retrieve the ip_address_type information. (added by ansible-collections/community.aws#499)
ISSUE TYPE
COMPONENT NAME
elb_application_lb_info
ADDITIONAL INFORMATION
I don't consider this a full fix for #1767 so I'm not using the "fixes".