Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with Ansible version 2.13 as the minimum supported version #1815

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Update README with Ansible version 2.13 as the minimum supported version #1815

merged 3 commits into from
Oct 20, 2023

Conversation

GomathiselviS
Copy link
Contributor

SUMMARY

The documentation for amazon.aws is updated with the current state of supported Ansible versions.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1dbda16d54634f09bc6959426ebceb1e

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 13m 13s

tremble
tremble approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this change. I'd prefer that there's also a review from the cloud content team before merging

tremble
tremble requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're dropping support for 2.12 We should also update runtime.yml:
https://github.com/ansible-collections/amazon.aws/blob/main/meta/runtime.yml#L2

alinabuzachis
alinabuzachis reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ansible-collections/amazon.aws/blob/main/meta/runtime.yml#L2 Must also be updated.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b04f25a81afd44c78c623ece8a4c9a16

✔️ ansible-galaxy-importer SUCCESS in 9m 16s
✔️ build-ansible-collection SUCCESS in 13m 11s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 26dbce8 into ansible-collections:main Oct 20, 2023
37 of 65 checks passed
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@GomathiselviS
Add pytest-ansible to test-requirement (ansible-collections#1815)
81ff07d 
* Add pytest-ansible

* Add python version cap for pytest-ansible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@gravesm gravesm Awaiting requested review from gravesm

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GomathiselviS @tremble @alinabuzachis