Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide github workflows to maintain consistency across all repos #1823

Merged

Conversation

GomathiselviS
Copy link
Contributor

SUMMARY

This PR creates separate workflows for changelog and linters tests.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@GomathiselviS GomathiselviS changed the title Divide github workflows for consistency Divide github workflows to maintain consistency across all repos Oct 20, 2023
@softwarefactory-project-zuul
Copy link
Contributor

@GomathiselviS GomathiselviS added the mergeit Merge the PR (SoftwareFactory) label Oct 20, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a8964852332544f9b7ed56a899e26c3c

✔️ ansible-galaxy-importer SUCCESS in 5m 28s
✔️ build-ansible-collection SUCCESS in 13m 01s

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@GomathiselviS GomathiselviS merged commit ad32403 into ansible-collections:main Oct 20, 2023
65 checks passed
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…lections#1824)

cloudfront_distribution: now honours the enabled setting

SUMMARY
Fixes: ansible-collections#1823
The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants