-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected the bug in examples for iam_instance_profile #1827
Conversation
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/iam_instance_profile_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/iam_instance_profile_module.html
index 8f448e9..e2c87af 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/iam_instance_profile_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/iam_instance_profile_module.html
@@ -399,16 +399,16 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-iam-inst
<section id="examples">
<h2><a class="toc-backref" href="#id5" role="doc-backlink">Examples</a><a class="headerlink" href="#examples" title="Link to this heading"></a></h2>
<div class="highlight-yaml+jinja notranslate"><div class="highlight"><pre><span></span><span class="p p-Indicator">-</span><span class="w"> </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">Find all existing IAM instance profiles</span>
-<span class="w"> </span><span class="nt">amazon.aws.iam_instance_profile_info</span><span class="p">:</span>
+<span class="w"> </span><span class="nt">amazon.aws.iam_instance_profile</span><span class="p">:</span>
<span class="w"> </span><span class="nt">register</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">result</span>
<span class="p p-Indicator">-</span><span class="w"> </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">Describe a single instance profile</span>
-<span class="w"> </span><span class="nt">amazon.aws.iam_instance_profile_info</span><span class="p">:</span>
+<span class="w"> </span><span class="nt">amazon.aws.iam_instance_profile</span><span class="p">:</span>
<span class="w"> </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">MyIAMProfile</span>
<span class="w"> </span><span class="nt">register</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">result</span>
<span class="p p-Indicator">-</span><span class="w"> </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">Find all IAM instance profiles starting with /some/path/</span>
-<span class="w"> </span><span class="nt">amazon.aws.iam_instance_profile_info</span><span class="p">:</span>
+<span class="w"> </span><span class="nt">amazon.aws.iam_instance_profile</span><span class="p">:</span>
<span class="w"> </span><span class="nt">prefile</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">/some/path/</span>
<span class="w"> </span><span class="nt">register</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">result</span>
</pre></div>
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 29s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to submit this PR. These examples were valid for iam_instance_profile_info which is designed for reading/listing profiles. However they're not valid for iam_instance_profile as it is designed for creating/modifying/deleting profiles.
It would probably be good to add 4 examples:
- Adding a profile with no path
- Adding a profile with a path
- Setting the role for a profile
- Deleting a profile
You can probably copy some of the tasks from our integration tests as examples - https://github.com/ansible-collections/amazon.aws/blob/main/tests/integration/targets/iam_instance_profile/tasks/main.yml
Could you please guide me how to do this? |
…sible-collections#1831) feat: add mq inventory plugin; addresses ansible-collections#1827 SUMMARY MQ broker inventory source ISSUE TYPE New Module Pull Request COMPONENT NAME aws_mq ADDITIONAL INFORMATION EXAMPLE USAGE: plugin: aws_mq regions: - ca-central-1 keyed_groups: - key: engine_type prefix: mq compose: app: 'tags.Applications|split(",")' hostvars_prefix: aws_ hostvars_suffix: _mq Reviewed-by: Alina Buzachis Reviewed-by: alialkhalidi Reviewed-by: Mark Chappell Reviewed-by: Mike Graves <[email protected]>
SUMMARY
In this pull request, I have corrected the bug because of which it was pointing to iam_instance_profile_info examples instead of itself. It Fixes #1811
ISSUE TYPE
COMPONENT NAME
NA
ADDITIONAL INFORMATION
I just corrected the file path in the file.
Could you please check once? Will be happy to learn and contribute more.