Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove changelog from all_green workflow #1833

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Remove changelog from all_green workflow #1833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/all_green_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ on: # yamllint disable-line rule:truthy
types:
- opened
- reopened
- labeled
- unlabeled
- synchronize
branches:
- main
Expand All @@ -20,8 +18,6 @@ on: # yamllint disable-line rule:truthy
- '*'

jobs:
changelog:
uses: ./.github/workflows/changelog.yml # use the callable changelog job to run tests
linters:
uses: ./.github/workflows/linters.yml # use the callable linters job to run tests
sanity:
Expand All @@ -31,15 +27,13 @@ jobs:
all_green:
if: ${{ always() }}
needs:
- changelog
- linters
- sanity
- units
runs-on: ubuntu-latest
steps:
- run: >-
python -c "assert set([
'${{ needs.changelog.result }}',
'${{ needs.linters.result }}',
'${{ needs.sanity.result }}',
'${{ needs.units.result }}'
Expand Down
20 changes: 17 additions & 3 deletions .github/workflows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,22 @@
---
name: changelog and linters

on: [workflow_call] # allow this workflow to be called from other workflows
name: changelog
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

on:
pull_request:
types:
- opened
- reopened
- labeled
- unlabeled
- synchronize
branches:
- main
- stable-*
tags:
- '*'
jobs:
changelog:
uses: ansible-network/github_actions/.github/workflows/changelog.yml@main
Loading