Commits on Nov 21, 2023

1. Work on ec2_vpc_subnet related test flake (#1848) …

   Work on ec2_vpc_subnet related test flake
   
   SUMMARY
   As with all things AWS there are no guarantees how fast things will be created.  We currently have a hard coded delay of ~10 seconds to wait for the subnet to be created, while advertising a default timeout of 300s.  If this 10s is exceeded, then we throw a 'NoneType' object is not subscriptable error (because we didn't check that the subnet was actually returned)
   This moves a for-loop over to a waiter.  The "waiter_handler" logic already makes sure we have a total waiting time matching the limits set, even if we wait for multiple things to happen)
   ISSUE TYPE
   
   Bugfix Pull Request
   
   COMPONENT NAME
   ec2_vpc_subnet
   ADDITIONAL INFORMATION
   2023-11-13 07:08:17.514752 | controller | TASK [ec2_ami_tpm : create a subnet to use for creating an ec2 instance] *******
   2023-11-13 07:08:17.514756 | controller | task path: /home/zuul-worker/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/ec2_ami_tpm/tasks/main.yml:31
   2023-11-13 07:08:29.688395 | controller | Using module file /home/zuul-worker/.ansible/collections/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py
   2023-11-13 07:08:29.688433 | controller | Pipelining is enabled.
   2023-11-13 07:08:29.688440 | controller | <testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul-worker
   2023-11-13 07:08:29.688481 | controller | <testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /home/zuul-worker/venv/bin/python && sleep 0'
   2023-11-13 07:08:29.688488 | controller | The full traceback is:
   2023-11-13 07:08:29.688494 | controller | Traceback (most recent call last):
   2023-11-13 07:08:29.688501 | controller |   File "<stdin>", line 121, in <module>
   2023-11-13 07:08:29.688508 | controller |   File "<stdin>", line 113, in _ansiballz_main
   2023-11-13 07:08:29.688514 | controller |   File "<stdin>", line 61, in invoke_module
   2023-11-13 07:08:29.688520 | controller |   File "<frozen runpy>", line 226, in run_module
   2023-11-13 07:08:29.688526 | controller |   File "<frozen runpy>", line 98, in _run_module_code
   2023-11-13 07:08:29.688533 | controller |   File "<frozen runpy>", line 88, in _run_code
   2023-11-13 07:08:29.688539 | controller |   File "/tmp/ansible_ec2_vpc_subnet_payload_g63mopop/ansible_ec2_vpc_subnet_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py", line 584, in <module>
   2023-11-13 07:08:29.688547 | controller |   File "/tmp/ansible_ec2_vpc_subnet_payload_g63mopop/ansible_ec2_vpc_subnet_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py", line 574, in main
   2023-11-13 07:08:29.688553 | controller |   File "/tmp/ansible_ec2_vpc_subnet_payload_g63mopop/ansible_ec2_vpc_subnet_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py", line 491, in ensure_subnet_present
   2023-11-13 07:08:29.688560 | controller |   File "/tmp/ansible_ec2_vpc_subnet_payload_g63mopop/ansible_ec2_vpc_subnet_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py", line 501, in ensure_final_subnet
   2023-11-13 07:08:29.688567 | controller | TypeError: 'NoneType' object is not subscriptable
   2023-11-13 07:08:29.688572 | controller | fatal: [testhost]: FAILED! => {
   2023-11-13 07:08:29.688579 | controller |     "changed": false,
   2023-11-13 07:08:29.688587 | controller |     "module_stderr": "Traceback (most recent call last):\n  File \"<stdin>\", line 121, in <module>\n  File \"<stdin>\", line 113, in _ansiballz_main\n  File \"<stdin>\", line 61, in invoke_module\n  File \"<frozen runpy>\", line 226, in run_module\n  File \"<frozen runpy>\", line 98, in _run_module_code\n  File \"<frozen runpy>\", line 88, in _run_code\n  File \"/tmp/ansible_ec2_vpc_subnet_payload_g63mopop/ansible_ec2_vpc_subnet_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py\", line 584, in <module>\n  File \"/tmp/ansible_ec2_vpc_subnet_payload_g63mopop/ansible_ec2_vpc_subnet_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py\", line 574, in main\n  File \"/tmp/ansible_ec2_vpc_subnet_payload_g63mopop/ansible_ec2_vpc_subnet_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py\", line 491, in ensure_subnet_present\n  File \"/tmp/ansible_ec2_vpc_subnet_payload_g63mopop/ansible_ec2_vpc_subnet_payload.zip/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_subnet.py\", line 501, in ensure_final_subnet\nTypeError: 'NoneType' object is not subscriptable\n",
   2023-11-13 07:08:29.688599 | controller |     "module_stdout": "",
   2023-11-13 07:08:29.688607 | controller |     "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
   2023-11-13 07:08:29.688614 | controller |     "rc": 1
   2023-11-13 07:08:29.688620 | controller | }
   
   See also:
   https://1c9f147019056ec08967-4a68a93a4e95f691374839dd8e3d025a.ssl.cf2.rackcdn.com/1846/7ae4218aaee617a59d13e46e8d0120456210b0fd/check/integration-amazon.aws-5/3714ce7/job-output.txt
   
   Reviewed-by: Alina Buzachis
   (cherry picked from commit c510f26)

   

   tremble authored and patchback[bot] committed Nov 21, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 60bac86
   • Browse repository at this point

   Copy the full SHA

   60bac86 View commit details

   Browse the repository at this point in the history