lookup/secretsmanager_secret - fix issue with missing nested secret and on_missing=warn #1972
Conversation
…user set on_missing=warn
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
abikouo
requested review from
tremble,
mandar242,
jillr,
hakbailey and
alinabuzachis
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 8m 51s |
There was a problem hiding this comment.
Tested PR changes locally, works as expected.
- without PR code fix
TASK [Read missing secret variable using 'on_missing==warn'] ************************************************************************
fatal: [localhost]: FAILED! => {"msg": "Successfully retrieved secret but there exists no key missing_err_secret in the secret"}
PLAY RECAP **************************************************************************************************************************
localhost : ok=1 changed=0 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0
- with PR code
TASK [Read missing secret variable using 'on_missing==warn'] ************************************************************************
[WARNING]: Skipping, Successfully retrieved secret but there exists no key missing_err_secret in the secret
ok: [localhost]
PLAY RECAP **************************************************************************************************************************
localhost : ok=2 changed=0 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
|
Build failed.
|
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 38s |
alinabuzachis
added
backport-7
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 33s |
softwarefactory-project-zuul
bot
merged commit 08e7d70
into
ansible-collections:main
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1974 🤖 @patchback |
…nd on_missing=warn (#1972) lookup/secretsmanager_secret - fix issue with missing nested secret and on_missing=warn SUMMARY Fixes #1781 The lookup was raising an error instead of a warning message ISSUE TYPE Bugfix Pull Request COMPONENT NAME lookup/secretsmanager_secret Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 08e7d70)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #1975 🤖 @patchback |
…nd on_missing=warn (#1972) lookup/secretsmanager_secret - fix issue with missing nested secret and on_missing=warn SUMMARY Fixes #1781 The lookup was raising an error instead of a warning message ISSUE TYPE Bugfix Pull Request COMPONENT NAME lookup/secretsmanager_secret Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Alina Buzachis (cherry picked from commit 08e7d70)
…nd on_missing=warn (#1972) (#1975) [PR #1972/08e7d700 backport][stable-7] lookup/secretsmanager_secret - fix issue with missing nested secret and on_missing=warn This is a backport of PR #1972 as merged into main (08e7d70). SUMMARY Fixes #1781 The lookup was raising an error instead of a warning message ISSUE TYPE Bugfix Pull Request COMPONENT NAME lookup/secretsmanager_secret Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell
…nd on_missing=warn (ansible-collections#1972) lookup/secretsmanager_secret - fix issue with missing nested secret and on_missing=warn SUMMARY Fixes ansible-collections#1781 The lookup was raising an error instead of a warning message ISSUE TYPE Bugfix Pull Request COMPONENT NAME lookup/secretsmanager_secret Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Alina Buzachis
SUMMARY
Fixes #1781
The lookup was raising an error instead of a warning message
ISSUE TYPE
COMPONENT NAME
lookup/secretsmanager_secret