Add utils for ec_vpc_peer* modules #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinabuzachis
force-pushed
the
ec2_vpc_peer_module_utils
branch
from
65b349e
to
3565890
Compare
abikouo
reviewed
Sep 27, 2024
plugins/module_utils/ec2.py
Outdated
|
|
||
| @classmethod | ||
| def _is_missing(cls): | ||
| return is_boto3_error_code("InvalidVpcPeeringConnectionID.NotFound", "InvalidVpcPeeringConnectionId.Malformed") |
There was a problem hiding this comment.
Suggested change
| return is_boto3_error_code("InvalidVpcPeeringConnectionID.NotFound", "InvalidVpcPeeringConnectionId.Malformed") | |
| return is_boto3_error_code(["InvalidVpcPeeringConnectionID.NotFound", "InvalidVpcPeeringConnectionId.Malformed"]) |
plugins/module_utils/ec2.py
Outdated
Comment on lines
333
to
336
| result = client.describe_vpc_peering_connections( | ||
| **params, | ||
| ) | ||
| return result |
There was a problem hiding this comment.
Suggested change
| result = client.describe_vpc_peering_connections( | |
| **params, | |
| ) | |
| return result | |
| paginator = client.get_paginator("describe_vpc_peering_connections") | |
| return paginator.paginate(**params).build_full_result()["VpcPeeringConnections"] |
The paginator exists for this API
alinabuzachis
force-pushed
the
ec2_vpc_peer_module_utils
branch
from
8899f4c
to
4d7afb0
Compare
abikouo
approved these changes
Oct 1, 2024
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
ec2_vpc_peer_module_utils
branch
from
4d7afb0
to
d0f8e6b
Compare
|
regate |
softwarefactory-project-zuul
bot
merged commit 1acdca4
into
ansible-collections:main
37 checks passed
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Oct 10, 2024
SUMMARY Depends-On: ansible-collections/amazon.aws#2303 Refactor ec2_vpc_peer* modules Once the module is migrated to amazon.aws I will deprecate result returned by the info module and rename the ec2_vpc_peer module (see #2154). ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ec2_vpc_peer ec2_vpc_peering_info ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add utils for ec_vpc_peer* modules
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION