Corrected spelling of word #2306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docs-links for stable-8 branch SUMMARY Now that stable-8 has branched, update some of the docs links so that stable-8 releases reference the stable-8 docs. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ort (ansible-collections#2089) (ansible-collections#2091) [PR ansible-collections#2089/f7c110ac backport][stable-8] RDS Integration tests - Bump MySQL/MariaDB versions to match AWS support This is a backport of PR ansible-collections#2089 as merged into main (f7c110a). SUMMARY Bump MySQL/MariaDB versions to match AWS support. AWS dropped the versions we were using in our integration tests, bump them ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance rds_option_group ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
…sible-collections#2025) (ansible-collections#2092) lambda_event - add support for maximum_batching_window_in_seconds SUMMARY Closes ansible-collections#1995 Fix when batch_size is greater than 10, by enabling support for setting maximum_batching_window_in_seconds. ISSUE TYPE Feature Pull Request COMPONENT NAME lambda_event Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell Reviewed-by: Helen Bailey <[email protected]> (cherry picked from commit b18ceba) Co-authored-by: Alina Buzachis <[email protected]>
…ble-collections#2095) [PR ansible-collections#2093/69512773 backport][stable-8] Drop support for ansible-core < 2.15 This is a backport of PR ansible-collections#2093 as merged into main (6951277). SUMMARY Drop support for ansible-core < 2.15. It modifies the already existing changelog. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
Signed-off-by: Alina Buzachis <[email protected]>
…lections#2108) (ansible-collections#2109) [PR ansible-collections#2108/48292178 backport][stable-8] s3_object - fix MemoryError when downloading large files This is a backport of PR ansible-collections#2108 as merged into main (4829217). SUMMARY fixes: ansible-collections#2107 The refactor in ansible-collections#1139 is triggering a full download of the file into memory when downloading files, this downloaded content was then being thrown away. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ied (ansible-collections#1979) (ansible-collections#2113) Don't ignore IPv6 addresses when a single network interface is specified SUMMARY When "ipv6_adresses" are used with "network" without specifying "interfaces", the parameter is ignored and no IPv6 adresses get set. I don't believe this is the intended or correct behaviour. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 0d1a604) Co-authored-by: C C Magnus Gustavsson <[email protected]>
…nsible-collections#2083) (ansible-collections#2122) [PR ansible-collections#2083/9c53b6c1 backport][stable-8] backup_plan_info: bugfix to enable getting info of all backup plans This is a backport of PR ansible-collections#2083 as merged into main (9c53b6c). SUMMARY Fix being unable to fetch info of all backup plans. With backup_plan_names being a required parameter, the functionality to get all plans info was not working # Gather information about all backup plans - name: Get info of all backup plans amazon.aws.backup_plan_info: register: plan_info_result gave ********** fatal: [localhost]: FAILED! => {"changed": false, "msg": "missing required arguments: backup_plan_names"} ISSUE TYPE Bugfix Pull Request COMPONENT NAME backup_plan_info ADDITIONAL INFORMATION
* Prep amazon.aws 8.0.1 Signed-off-by: Alina Buzachis <[email protected]> * update aws user-agent variable with version from galaxy.yml --------- Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: alinabuzachis <[email protected]>
…ections#2146) This is a backport of PR ansible-collections#2143 as merged into main (0ebab2b). SUMMARY Fix back-ticks in changelogs ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
ansible-collections#2148) This is a backport of PR ansible-collections#2141 as merged into main (52d3965). SUMMARY Amazon's dropping support for M4/R4/T2 RDS DB instances, replace their use in tests before something suddenly fails. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ttings parameter (ansible-collections#2124) (ansible-collections#2129) This is a backport of PR ansible-collections#2124 as merged into main (7c1d8aa). Fixes ansible-collections#2110 This PR adds an example to showcase the usage of advanced_backup_settings parameter adds option in args spec and suboption in module doc SUMMARY ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
…llections#2154) Add support for S3 Bucket Transfer Acceleration: https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html Reviewed-by: Helen Bailey [email protected] Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves [email protected] (cherry picked from commit 3a6e448) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]>
…lections#2176) (cherry picked from commit 420418c) Co-authored-by: Felix Fontein <[email protected]>
…le-collections#2062) (ansible-collections#2177) SUMMARY https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-configure.html#object-lock-configure-set-retention-period-object Design detail: AWS API doesn't support unsetting the default retention, though it is possible in the Web console. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket Reviewed-by: Helen Bailey [email protected] Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves [email protected] (cherry picked from commit c2e7aaf) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]> Reviewed-by: GomathiselviS
* Prep amazon.aws 8.1.0 Signed-off-by: Alina Buzachis <[email protected]> * update aws user-agent variable with version from galaxy.yml --------- Signed-off-by: Alina Buzachis <[email protected]> Co-authored-by: alinabuzachis <[email protected]>
…sible-collections#2188) (ansible-collections#2190) This is a backport of PR ansible-collections#2188 as merged into main (2f1fcab). SUMMARY Refer: https://issues.redhat.com/browse/ACA-1691 Requires mattclay/aws-terminator#304 for permissions. Some of the ec2 instance types used in the integration tests are switched to t3a.micro to avoid intermittent failures in the CI ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…nsible-collections#2185) (ansible-collections#2187) This is a backport of PR ansible-collections#2185 as merged into main (3c6ba70). SUMMARY Adds "alternative" key to documentation for deprecated EC2_REGION env variable. ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/doc_fragments/region.py ADDITIONAL INFORMATION Fixes sanity issue: ERROR: Found 5 validate-modules issue(s) which need to be resolved: ERROR: plugins/inventory/aws_ec2.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None ERROR: plugins/inventory/aws_rds.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None ERROR: plugins/lookup/aws_account_attribute.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None ERROR: plugins/lookup/secretsmanager_secret.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None ERROR: plugins/lookup/ssm_parameter.py:0:0: invalid-documentation: DOCUMENTATION.options.region.env.1.deprecated.Any('alternatives', 'alternative', msg=None): required key not provided @ data['options']['region']['env'][1]['deprecated'][Any('alternatives', 'alternative', msg=None)]. Got None Reviewed-by: Mark Chappell
…s#2222) (ansible-collections#2223) This is a backport of PR ansible-collections#2222 as merged into main (0dbac7a). SUMMARY fixes ansible-collections#2220 Removes the default for accelerate_enabled: having the default explicitly set to false breaks idempotency when only passed partial configuration having the default explicitly set results in the module always failing on non-AWS platforms ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ansible-collections#2211) (ansible-collections#2224) This is a backport of PR ansible-collections#2211 as merged into main (8d28fc4). SUMMARY Add fetch by ARN to integration test (test ansible-collections#1695) ISSUE TYPE Feature Pull Request COMPONENT NAME secretsmanager_secret ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…s the correct formats (ansible-collections#2086) (ansible-collections#2230) This is a backport of PR ansible-collections#2086 as merged into main (7039af0). SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…le-collections#2231) This is a backport of PR ansible-collections#2195 as merged into main (bcca150). SUMMARY Updated return block of following modules - iam_instance_profile_info - iam_managed_policy - iam_password_policy - iam_policy - iam_policy_info - iam_role - iam_user - iam_user_info ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ible-collections#2221) (ansible-collections#2232) This is a backport of PR ansible-collections#2221 as merged into main (7227664). SUMMARY Before the addition of iam_instance_profile the only way to create instance profiles was through iam_role. We now have a dedicated module. With the principle of "do one thing and do it well", let's formally deprecate support for creating/deleting instance profiles from the iam_role module. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION There's also some kind of issue around profiles already existing (see ansible-collections#2102 ) Reviewed-by: Mark Chappell
…nsible-collections#2204) This is a backport of PR ansible-collections#2182 as merged into main (3320689). SUMMARY Because the instances created in the default VPC are not directly deleted we may faced some capacity issue while running some CI validation. ISSUE TYPE Feature Pull Request COMPONENT NAME CI Reviewed-by: Mark Chappell
ansible-collections#2235) This is a backport of PR ansible-collections#2144 as merged into main (4ffbda3). SUMMARY Updated return block of following modules - kms_key - kms_key_info ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
… (ansible-collections#2234) This is a backport of PR ansible-collections#2137 as merged into main (f087af3). SUMMARY Refer https://issues.redhat.com/browse/ACA-1477 This PR updates the return block in the route53_health_check module documentation. ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…sible-collections#2233) This is a backport of PR ansible-collections#2132 as merged into main (657f32d). SUMMARY This PR updates the return blocks for lambda modules. Refer: https://issues.redhat.com/browse/ACA-1478 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ollections#2135) (ansible-collections#2236) SUMMARY Updated return block of following modules s3_bucket s3_bucket_info s3_object ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Manual backport (because ansible-collections#2062 / ansible-collections#2177 was manually backported) Reviewed-by: Alina Buzachis
…collections#2238) This is a backport of PR ansible-collections#2151 as merged into main (35f0d57). SUMMARY elb_* - Update RETURN block docs ISSUE TYPE Docs Pull Request COMPONENT NAME elb_* ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…s the correct formats (ansible-collections#2088) (ansible-collections#2239) This is a backport of PR ansible-collections#2088 as merged into main (a58acd3). SUMMARY Ensures the modules documentation follows the correct formats ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…metric_alarm: include evaluate_low_sample_count_percentile (ansible-collections#2255) This is a backport of PR ansible-collections#2111 as merged into main (2389122). SUMMARY Fixes ansible-collections#1940 This PR adds evaluate_low_sample_count_percentile parameter ISSUE TYPE Feature Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ansible-collections#1865) (ansible-collections#2256) This is a backport of PR ansible-collections#1865 as merged into main (dc574ca). SUMMARY A metric alarm in Cloudwatch can optionally have Dimensions. When a metric alarm in Cloudwatch does not have any dimensions, it returns: "Dimensions": [] when queried via boto3. When configuring a metric alarm without Dimensions in Cloudwatch using the cloudwatch_metric_alarm plugin, Dimensions must be absent from the parameters. Because "Dimensions": [] does not match Dimensions: None, the result is always Changed. This Pull Request fixes this by setting Dimensions from the returned alarm parameters to None when the field is empty. Fixes ansible-collections#1750 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudwatch_metric_alarm ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ble-collections#2196) (ansible-collections#2257) This is a backport of PR ansible-collections#2196 as merged into main (f003163). SUMMARY module cloudwatch_metric_alarm support DatapointsToAlarm config ansible-collections#2193 ISSUE TYPE Feature Pull Request COMPONENT NAME cloudwatch_metric_alarm Reviewed-by: Mark Chappell
…ons#2136) (ansible-collections#2260) This is a backport of PR ansible-collections#2136 as merged into main (b56f708). SUMMARY Refer https://issues.redhat.com/browse/ACA-1477 Route53 module, returns after and before diff as module output. This PR fixes this bug, by adding a check to return the diff only when module._diff is set to true. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…aurora clusters (ansible-collections#2063) (ansible-collections#2259) This is a backport of PR ansible-collections#2063 as merged into main (579f7a3). SUMMARY Adds support for I/O-Optimized storage configuration for aurora clusters Fixes ansible-collections#2038 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_cluster ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…ns#2123) (ansible-collections#2258) SUMMARY Closes ansible-collections#2054 JIRA: https://issues.redhat.com/browse/ACA-1382 ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME ec2_instance Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin Reviewed-by: Mark Chappell (cherry picked from commit f7d7ffa) Co-authored-by: Bikouo Aubin <[email protected]>
…ansible-collections#2209) (ansible-collections#2210) Depends-On: ansible-collections#2258 This is a backport of PR ansible-collections#2209 as merged into main (5756ac4). Fixes: ansible-collections#2205 SUMMARY ec2_metadata_facts sometimes returns 401 unauthorized if the IMDSv2 token times out. The token TTL is currently hardcoded to 60, this pull request aims to make it configurable. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metadata_facts Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis
…s_az_region_info* modules (PARTIAL BACKPORT) (ansible-collections#2261) This is a PARTIAL backport of PR ansible-collections#2163 as merged into main (42675e2). Bringing back only the integration test cleanup SUMMARY Refactor aws_az_info,aws_region_info modules ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance Reviewed-by: Mark Chappell
…-collections#2262) This is a backport of PR ansible-collections#2191 as merged into main (3274b28). SUMMARY ec2_instance tests aren't deleting the placement groups they created (and the cleanup lambda isn't deleting them either) ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/ec2_instance_placement_options/tasks/main.yml ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…lections#2219) (ansible-collections#2251) This is a manual backport of PR ansible-collections#2219 as merged into main (1f65ad9). SUMMARY performance_insights_kms_key_id parameter has a variation in AWS snake case Fixes ansible-collections#2217 ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance - parameter: performance_insights_kms_key_id ADDITIONAL INFORMATION I have successfully created an rds_instance instance w/ correct custom performance_insights_kms_key_id (not the default: "aws/rds") Reviewed-by: Mark Chappell Reviewed-by: Gabriel PREDA Reviewed-by: Alina Buzachis Reviewed-by: Helen Bailey <[email protected]>
…tes (ansible-collections#2263) (ansible-collections#2265) This is a backport of PR ansible-collections#2263 as merged into main (0bca4b9). SUMMARY A number of PRs got backported late/early and as such don't match up with their "version_added" information in the docs. ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/cloudwatch_metric_alarm.py plugins/modules/ec2_instance.py plugins/modules/rds_cluster.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…er acceleration (ansible-collections#2267) (ansible-collections#2269) This is a backport of PR ansible-collections#2267 as merged into main (db552aa). fixes: ansible-collections#2266 SUMMARY While ansible-collections#2202 (combined with ansible-collections#2222) fixes the issue for the aws-gov partition, the aws partition throws a different Error (MethodNotAllowed). I suspect the two different exceptions are a side effect of how AWS implement the Gov-Cloud partition vs the normal partition. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION See also: ansible-collections#2266 Reviewed-by: Mark Chappell
…nsible-collections#2268) (ansible-collections#2270) This is a backport of PR ansible-collections#2268 as merged into main (610fd8c). SUMMARY This fixes the failure seen in https://d04ed4904ec3d4928496-5828abdaefb23a8975ffbcdc8ff7f222.ssl.cf1.rackcdn.com/2227/82e7cd3fcc15efebea7c6fbbcb447e99449af9d3/check/integration-amazon.aws-1/baa1dcd/job-output.txt TASK [Set image id, vpc cidr and subnet cidr] ********************************** 2024-08-23 20:07:43.220507 | controller | task path: /home/zuul-worker/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/inventory_aws_ec2/playbooks/tasks/setup.yml:13 2024-08-23 20:07:43.220523 | controller | fatal: [127.0.0.1]: FAILED! => { 2024-08-23 20:07:43.222302 | controller | "msg": "The task includes an option with an undefined variable. The error was: list object has no element 0\n\nThe error appears to be in '/home/zuul-worker/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/inventory_aws_ec2/playbooks/tasks/setup.yml': line 13, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Set image id, vpc cidr and subnet cidr\n ^ here\n" 2024-08-23 20:07:43.222349 | controller | } AMIs can be deprecated to indicate they are outdated or no longer actively maintained. Fedora-Cloud-Base-37-1.2.x86_64* ami is not available. ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…lections#2273) This is a backport of PR ansible-collections#2074 as merged into main (c96d250). SUMMARY Add S3 inventory support - https://docs.aws.amazon.com/AmazonS3/latest/userguide/storage-inventory.html ISSUE TYPE Feature Pull Request COMPONENT NAME S3 Bucket Reviewed-by: Mark Chappell
…ansible-collections#2274) This is a backport of PR ansible-collections#1756 as merged into main (c535e63). SUMMARY In the event that there exists two parameters in Parameter Store path/to/params/foo/bar/param and path/to/params/x/y/param, a user attempting to recursively pull all parameters under the path/to/params path with the command {{ lookup('amazon.aws.aws_ssm', '/PATH/to/params', region='ap-southeast-2', shortnames=true, bypath=true, recursive=true ) }}" will be unable to use the shortnames argument without creating a conflict between the two param results. Only one param key will exist in the resulting dictionary. This is problematic for users that wish to lookup a parameter hierarchy with repetitive names in the final value of the parameter path. In this scenario, users are currently forced to use the fully qualified parameter name when interacting with their dictionary results. This pull request introduces the droppath option, which will drop the common lookup path from the names of all parameters. In the scenario above, the resulting dictionary would contain both a foo/bar/param and a /x/y/param allowing users to refer to them by their minimally differentiated name. ISSUE TYPE Feature Pull Request COMPONENT NAME lookup ADDITIONAL INFORMATION Step by step Setup Create parameter path/to/params/foo/bar/param with value abc Create parameter path/to/params/x/y/param with value 123 Run shortnames name: return a dictionary of ssm parameters from a hierarchy path with shortened names (param instead of /PATH/to/param) debug: msg="{{ lookup('amazon.aws.aws_ssm', '/PATH/to/params', region='ap-southeast-2', shortnames=true, bypath=true, recursive=true ) }}" Observe result {'param': '123'} Run droppath name: return a dictionary of ssm parameters from a hierarchy path with shortened names (param instead of /PATH/to/param) debug: msg="{{ lookup('amazon.aws.aws_ssm', '/PATH/to/params', region='ap-southeast-2', droppath=true, bypath=true, recursive=true ) }}" Observe result {'/foo/bar/param': 'abc', '/x/y/param': '123'} Run both name: return a dictionary of ssm parameters from a hierarchy path with shortened names (param instead of /PATH/to/param) debug: msg="{{ lookup('amazon.aws.aws_ssm', '/PATH/to/params', region='ap-southeast-2', droppath=true, shortnames = true, bypath=true, recursive=true ) }}" Observe error shortnames and droppath are mutually exclusive. They cannot both be set to true. Reviewed-by: Mark Chappell
…-collections#1659) (ansible-collections#2276) This is a MANUAL backport of PR ansible-collections#1659 as merged into main (26d7243). SUMMARY Fixes (ie adds) 'state' processing for ec2_instance when 'exact_count' is used rather than 'instance_ids' Note this only has effect when the exact_count is the same as the number of already existing, matching instances. In other words, it (still) has no effect when instances are either added or terminated as a result of exact_count. This is probably OK, as those other cases already have set target states (ie running or terminated respectively). But for the cases of managing the state of an existing group of instances, this adds that ability. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Currently, given an ec2_instance call where exact_count == existing instance count, any specification of 'state' has no effect. Reviewed-by: Bikouo Aubin
SUMMARY
Prep amazon.aws 8.2.0
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
several
ADDITIONAL INFORMATION
---------
Approved By: Mark Chappell
Approved By: Aubin Bikouo
…en not creating a profile (ansible-collections#2282) (ansible-collections#2283) This is a backport of PR ansible-collections#2282 as merged into main (4867e68). fixes: ansible-collections#2102 fixes: ansible-collections#2281 SUMMARY ansible-collections#2221 deprecation logic accidentally forced create_instance_profile to True The IAM refactor made iam_role sensitive to pre-existing instance profiles with the same name. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
SUMMARY Prep amazon.aws 8.2.1 release. Release date is set to tomorrow. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Mandar Kulkarni <[email protected]>
…sible-collections#2290) This is a backport of PR ansible-collections#2288 as merged into main (55460c9). Fixes: ansible-collections#2287 SUMMARY Support for type hinting generics in standard collections was first added in Python 3.9. We're currently not running the sanity tests against Python 3.7 (including the compilation/import tests), so we missed this. (We currently test 3.9-3.12) Using quay.io/ansible/default-test-container:8.12.0 locally to run the tests against 3.7 I see: (2.7 and 3.6 are skipped because this collection doesn't support them) Running sanity test "import" on Python 2.7 Running sanity test "import" on Python 3.6 Running sanity test "import" on Python 3.7 ERROR: Found 1 import issue(s) on python 3.7 which need to be resolved: ERROR: plugins/modules/s3_bucket.py:571:0: traceback: TypeError: 'type' object is not subscriptable See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/import.html Running sanity test "import" on Python 3.8 ERROR: Found 1 import issue(s) on python 3.8 which need to be resolved: ERROR: plugins/modules/s3_bucket.py:571:0: traceback: TypeError: 'type' object is not subscriptable See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/import.html Running sanity test "import" on Python 3.9 Running sanity test "import" on Python 3.10 Running sanity test "import" on Python 3.11 Running sanity test "import" on Python 3.12 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
SUMMARY Fix sanity errors occurring with the devel branch of ansible ERROR: Found 2 pylint issue(s) which need to be resolved: ERROR: plugins/modules/ec2_vpc_endpoint.py:441:24: used-before-assignment: Using variable 'result' before assignment ERROR: plugins/modules/ec2_vpc_route_table.py:792:7: used-before-assignment: Using variable 'route_table' before assignment See ansible-collections#2295 ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Corrected spelling of the word to
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/ec2_instance_module.html b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/ec2_instance_module.html
index 0c4be41..cf927ad 100644
--- a/home/runner/work/amazon.aws/amazon.aws/docsbuild/base/collections/amazon/aws/ec2_instance_module.html
+++ b/home/runner/work/amazon.aws/amazon.aws/docsbuild/head/collections/amazon/aws/ec2_instance_module.html
@@ -194,7 +194,7 @@ see <a class="reference internal" href="#ansible-collections-amazon-aws-ec2-inst
</div></td>
<td><div class="ansible-option-cell"><p>Preconfigured user-data to enable an instance to perform an Ansible Automation Platform callback (Linux only).</p>
<p>For Windows instances, to enable remote access via Ansible set <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-aap-callback-windows"><span class="std std-ref"><span class="pre">aap_callback.windows</span></span></a></strong></code> to <code class="ansible-value docutils literal notranslate"><span class="pre">true</span></code>, and optionally set an admin password.</p>
-<p>If using <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-aap-callback-windows"><span class="std std-ref"><span class="pre">aap_callback.windows</span></span></a></strong></code> and <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-aap-callback-set-password"><span class="std std-ref"><span class="pre">aap_callback.set_password</span></span></a></strong></code>, callback ton Ansible Automation Platform will not be performed but the instance will be ready to receive winrm connections from Ansible.</p>
+<p>If using <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-aap-callback-windows"><span class="std std-ref"><span class="pre">aap_callback.windows</span></span></a></strong></code> and <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-aap-callback-set-password"><span class="std std-ref"><span class="pre">aap_callback.set_password</span></span></a></strong></code>, callback to Ansible Automation Platform will not be performed but the instance will be ready to receive winrm connections from Ansible.</p>
<p>Mutually exclusive with <code class="ansible-option docutils literal notranslate"><strong><a class="reference internal" href="#ansible-collections-amazon-aws-ec2-instance-module-parameter-user-data"><span class="std std-ref"><span class="pre">user_data</span></span></a></strong></code>.</p>
</div></td>
</tr>
|
alinabuzachis
approved these changes
Sep 24, 2024
alinabuzachis
added
the
backport-8
|
@Figrol Thank you for working on this. Can you please rebase your main your branch? |
abikouo
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected spelling of the word to
SUMMARY
Small spelling mistake the current word of "ton" does not make sense and assume it should be "to".
ISSUE TYPE
COMPONENT NAME
Doc spelling correction
ADDITIONAL INFORMATION