Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix win_user_right ansible module integration test assertions #666

Conversation

shahargolshani
Copy link
Contributor

SUMMARY
  • Fix win_user_right module integration test
  • Fix win_user_right module ansible-lint warnings and errors
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_user_right ansible-test windows-integration

ADDITIONAL INFORMATION

Fix win_user_right variable extraction in ansible.builtin.assert tasks
Fix ansible.lint static code test warnings and errors

Fix the following test failures:

fatal: [windows_server]: FAILED! =>
{"msg": "The conditional check 'set_administrator_check.added[0]|upper == '{{ansible_hostname|upper}}\\{{ admin_account_name|upper }}'' failed. 
The error was: Conditional is marked as unsafe, and cannot be evaluated."}

Copy link

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

@github-actions github-actions bot added the stale label Nov 13, 2024
@jborean93 jborean93 closed this Nov 14, 2024
@jborean93 jborean93 reopened this Nov 14, 2024
@jborean93 jborean93 force-pushed the bugfix/fix_win_user_right_assertion branch from 499eac0 to 17ecee7 Compare November 19, 2024 00:17
@jborean93 jborean93 merged commit fbe2dc5 into ansible-collections:main Nov 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants