Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate win_certificate_info module to ansible.windows repo from ansible.community repo #687

Merged

Conversation

ronger4
Copy link
Contributor

@ronger4 ronger4 commented Nov 3, 2024

SUMMARY
  • Migration of win_certificate_info module from community repo to ansible.windows repo.
  • Added extra integration test for store_location: CurrentUser.
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

win_certificate_info

ADDITIONAL INFORMATION

After this PR is pushed, we need to add a deprecation message in the documentation of win_certificate_info module in ansible.community


Copy link
Contributor

@Yaish25491 Yaish25491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks grate, Added 1 minor comment.

@ronger4 ronger4 force-pushed the migrate_win_certificate_info branch 2 times, most recently from 64f5490 to b9ff72d Compare November 6, 2024 12:59
module: win_certificate_info
short_description: Get information on certificates from a Windows Certificate Store
description:
- Returns information about certificates in a Windows Certificate Store.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set the version when this module was added to the collection through the version_added key.

Suggested change
- Returns information about certificates in a Windows Certificate Store.
- Returns information about certificates in a Windows Certificate Store.
version_added: 2.6.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason you put 2.6.0 because it will be the upcoming version release, right?

Is there a place where we can follow the planned release dates if there is such

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is in the galaxy.yml file and while sometimes it may have already been bumped it may still track the older release. I just compare it with the tagged releases and see if I need to increment it or not. In this case 2.5.0 is the latest release and the galaxy.yml has not been updated yet. A minor version bump is needed for new features so the next release will be 2.6.0.

As for a release schedule there hasn't been a hard rule of when to release. I usually aim for a release every 1-2 months but that is also dependent on whether there are changes to be made in a release.

plugins/modules/win_certificate_info.py Show resolved Hide resolved
@ronger4 ronger4 force-pushed the migrate_win_certificate_info branch from b9ff72d to 7496544 Compare November 7, 2024 08:26
@jborean93
Copy link
Collaborator

Thanks, let's hold off for now on deprecating the community.windows variant as we need to sort out the next release timings and what other ones we want to migrate across for the next release. We can do the deprecations at the end.

@jborean93 jborean93 merged commit eeca23e into ansible-collections:main Nov 7, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants