-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate win_certificate_info module to ansible.windows repo from ansible.community repo #687
Migrate win_certificate_info module to ansible.windows repo from ansible.community repo #687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks grate, Added 1 minor comment.
64f5490
to
b9ff72d
Compare
module: win_certificate_info | ||
short_description: Get information on certificates from a Windows Certificate Store | ||
description: | ||
- Returns information about certificates in a Windows Certificate Store. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to set the version when this module was added to the collection through the version_added
key.
- Returns information about certificates in a Windows Certificate Store. | |
- Returns information about certificates in a Windows Certificate Store. | |
version_added: 2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason you put 2.6.0 because it will be the upcoming version release, right?
Is there a place where we can follow the planned release dates if there is such
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version is in the galaxy.yml file and while sometimes it may have already been bumped it may still track the older release. I just compare it with the tagged releases and see if I need to increment it or not. In this case 2.5.0
is the latest release and the galaxy.yml
has not been updated yet. A minor version bump is needed for new features so the next release will be 2.6.0
.
As for a release schedule there hasn't been a hard rule of when to release. I usually aim for a release every 1-2 months but that is also dependent on whether there are changes to be made in a release.
…ble.community repo
b9ff72d
to
7496544
Compare
Thanks, let's hold off for now on deprecating the |
SUMMARY
ISSUE TYPE
COMPONENT NAME
win_certificate_info
ADDITIONAL INFORMATION
After this PR is pushed, we need to add a deprecation message in the documentation of win_certificate_info module in ansible.community