Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_firewall - Migrate from community #709

Merged

Conversation

shahargolshani
Copy link
Contributor

SUMMARY
  • Promote the win_firewall Module from community with git history
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

plugins/modules/win_firewall.ps1
plugins/modules/win_firewall.py
tests/integration/targets/win_firewall/aliases
tests/integration/targets/win_firewall/tasks/main.yml
tests/integration/targets/win_firewall/tasks/tests.yml

ADDITIONAL INFORMATION
  • Migrating all history commits related to files/folders of win_firewall module
  • Upgrade to Ansible.Basic style
  • Fix tests bug - Fix subsequent integration test run failures due to inbound/outbound values not restored after test.

jborean93 and others added 11 commits March 6, 2020 07:14
* Fix up docs after migration

* Fix up sanity errors
…e. (ansible-collections#136)

* New feature

* fix changes

* added not_configured, remove unwanted return values

* Fix whitespaces

* fix documentation,modify code

* integration test

* fix integration test
* fix gpoBoolean and Boolean comparation

fix gpoBoolean and Boolean comparation in windows 8.1 and win server 12r2 (with PS/WMF 4.x)

* append changelog

add changelog message about firewall bools comparation fix

* rename changelog fragment

rename changlog fragment (firewall... -> win_firewall)
This removes all the deprecated options, aliases, modules in time for
the 2.0.0 release of the collection. It also deprecates the
win_domain_computer, win_domain_group, win_domain_group_membership,
win_domain_object_info, win_domain_ou, and win_domain_user modules in
favour of the microsoft.ad collection equivalents.
@shahargolshani shahargolshani force-pushed the migrate-win_firewall branch 3 times, most recently from a69a25a to 7580335 Compare December 5, 2024 15:51
@jborean93 jborean93 merged commit c056468 into ansible-collections:main Dec 8, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants